Skip to content

fix: improve navigation responsiveness on small screens - #561

Open
priyaamore wants to merge 1 commit into
accordproject:mainfrom
priyaamore:fix-responsive-navigation
Open

priyaamore wants to merge 1 commit into
accordproject:mainfrom
priyaamore:fix-responsive-navigation

Conversation

@priyaamore

@priyaamore priyaamore commented Oct 24, 2026 •

Copy link
Copy Markdown

Closes #

Changes

  • Fixed responsive navigation layout issues on small screens, including 340px viewport widths.
  • Updated CSS to prevent navigation elements from overlapping on narrow screens.
  • Verified that the website compiles successfully and tested the layout locally.

Flags

  • No breaking changes.
  • No new dependencies added intentionally.

Screenshots or Video

image

Related Issues

Author Checklist

  • Vital features and changes captured in unit and/or integration tests
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: Priya More <priyamore8446@gmail.com>
@priyaamore
priyaamore force-pushed the fix-responsive-navigation branch from 34c35c7 to 41374ed Compare October 24, 2026 16:54
@priyaamore

Copy link
Copy Markdown
Author

Hi 👋

I've fixed the responsive navigation issue and verified the changes locally. All automated checks have passed, including the DCO check.

Could you please review my PR when you get a chance? I'd appreciate your feedback.

Thank you for your time and for maintaining Accord Project! 😊

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

This PR is stale because it has been open with no activity. Remove the stale label or comment to keep it active. Only items with maintainer engagement are auto-closed.

@github-actions github-actions Bot added the Stale label Nov 9, 2026
@priyaamore

Copy link
Copy Markdown
Author

Issue had been solved
Could you please review my PR when you get a chance? I'd appreciate your feedback.

@mira-accord-project mira-accord-project Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, and for including a screenshot. The new .navbar-sidebar__brand rules are a sensible way to stop the logo, title and close button overlapping in the mobile sidebar. One change needs undoing before this can merge: the existing homepage @media (max-width: 768px) block was switched to 340px, which changes the homepage layout on most phones and tablets. If you restore that query to 768px and drop the unrelated package-lock.json change, this becomes a small CSS-only fix and is ready for a maintainer to review.

Changes are needed before this can merge. Findings: 1 blocking, 1 should-fix, 1 nit.

  • should-fix · hygiene · website/package-lock.json: The only lockfile change is the removed "hasInstallScript": true line in the root package entry. It most likely comes from running npm install with a different npm version, and it isn't needed for a CSS fix. It also means a maintainer has to review a dependency file. Please revert website/package-lock.json (for example git checkout upstream/main -- website/package-lock.json) so the PR only touches custom.css.
  • nit · design · website/src/css/custom.css: PR #564 tackles the same sidebar header overlap by restyling .navbar-sidebar__brand and .navbar-sidebar__close, but in website/static/css/main.css. If both were merged, two sets of rules would target the same header. It would help to mention #564 in the description and link the issue this fixes (the Closes # line is still the template placeholder), so maintainers can choose one approach.

Automated review by Mira, an Accord Project agent, at 41374ed. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.


/* ===== RESPONSIVE ===== */
@media (max-width: 768px) {
@media (max-width: 340px) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking · correctness

This line changes the existing homepage breakpoint from max-width: 768px to max-width: 340px. That block is what stacks the .blockElement.imageAlignRight / .imageAlignLeft image-and-text rows into a column, lets .blockImage img use the full width, and shrinks .homeContainer .projectTitle to 2rem. With 340px, screens from 341px to 768px wide (most phones and small tablets) get the side-by-side rows and the 2.8rem title again, so the homepage layout breaks there. Please put this query back to 768px. Your new navbar rules already have their own @media (max-width: 340px) block at the end of the file, so they don't need this one.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant