Repository navigation
fix: improve navigation responsiveness on small screens - #561
priyaamore wants to merge 1 commit into
Conversation
Signed-off-by: Priya More <priyamore8446@gmail.com>
34c35c7 to
41374ed
Compare
|
Hi 👋 I've fixed the responsive navigation issue and verified the changes locally. All automated checks have passed, including the DCO check. Could you please review my PR when you get a chance? I'd appreciate your feedback. Thank you for your time and for maintaining Accord Project! 😊 |
|
This PR is stale because it has been open with no activity. Remove the stale label or comment to keep it active. Only items with maintainer engagement are auto-closed. |
|
Issue had been solved |
There was a problem hiding this comment.
Thank you for this, and for including a screenshot. The new .navbar-sidebar__brand rules are a sensible way to stop the logo, title and close button overlapping in the mobile sidebar. One change needs undoing before this can merge: the existing homepage @media (max-width: 768px) block was switched to 340px, which changes the homepage layout on most phones and tablets. If you restore that query to 768px and drop the unrelated package-lock.json change, this becomes a small CSS-only fix and is ready for a maintainer to review.
Changes are needed before this can merge. Findings: 1 blocking, 1 should-fix, 1 nit.
- should-fix · hygiene ·
website/package-lock.json: The only lockfile change is the removed"hasInstallScript": trueline in the root package entry. It most likely comes from runningnpm installwith a different npm version, and it isn't needed for a CSS fix. It also means a maintainer has to review a dependency file. Please revertwebsite/package-lock.json(for examplegit checkout upstream/main -- website/package-lock.json) so the PR only touchescustom.css. - nit · design ·
website/src/css/custom.css: PR #564 tackles the same sidebar header overlap by restyling.navbar-sidebar__brandand.navbar-sidebar__close, but inwebsite/static/css/main.css. If both were merged, two sets of rules would target the same header. It would help to mention #564 in the description and link the issue this fixes (theCloses #line is still the template placeholder), so maintainers can choose one approach.
Automated review by Mira, an Accord Project agent, at 41374ed. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.
|
|
||
| /* ===== RESPONSIVE ===== */ | ||
| @media (max-width: 768px) { | ||
| @media (max-width: 340px) { |
There was a problem hiding this comment.
blocking · correctness
This line changes the existing homepage breakpoint from max-width: 768px to max-width: 340px. That block is what stacks the .blockElement.imageAlignRight / .imageAlignLeft image-and-text rows into a column, lets .blockImage img use the full width, and shrinks .homeContainer .projectTitle to 2rem. With 340px, screens from 341px to 768px wide (most phones and small tablets) get the side-by-side rows and the 2.8rem title again, so the homepage layout breaks there. Please put this query back to 768px. Your new navbar rules already have their own @media (max-width: 340px) block at the end of the file, so they don't need this one.
Closes #
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist