Skip to content

update accord website css issue #556 - #559

Open
ankitapradhans wants to merge 1 commit into
accordproject:mainfrom
ankitapradhans:#1-issue
Open

ankitapradhans wants to merge 1 commit into
accordproject:mainfrom
ankitapradhans:#1-issue

Conversation

@ankitapradhans

@ankitapradhans ankitapradhans commented Oct 11, 2026 •

Copy link
Copy Markdown

Closes #

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: ankitapradhans <ankitapradhan2103@gmail.com>
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open with no activity. Remove the stale label or comment to keep it active. Only items with maintainer engagement are auto-closed.

@mira-accord-project mira-accord-project Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking up #556, Ankita, and for keeping the change small and focused. The idea of stacking the hero buttons on narrow screens is the right one, but as written the CSS doesn't yet change the layout at the width reported in the issue (~390px), and the rule it adds is partly overridden by website/static/css/main.css. To make this mergeable: move the fix to a breakpoint that covers ~390px, target the hero's flex container (or use selectors specific enough to win), check it in a browser at 360px and 390px, and fill in the PR description with a before/after screenshot.

Changes are needed before this can merge. Findings: 1 blocking, 2 should-fix, 1 nit.

  • should-fix · docs: The PR description is still the unfilled template: Closes #<CORRESPONDING ISSUE NUMBER>, the <ONE>/<TWO> placeholders, and no screenshots. The checklist also has boxes ticked (tests, docs) that don't apply to this change. Please replace the placeholders with a short description, write Closes #556 so GitHub links the issue, and add a before/after screenshot at ~360px and ~390px, which will help reviewers confirm the fix.
  • nit · design · website/src/css/custom.css: A few other open PRs also address the hero button overlap in #556, so a maintainer will need to choose one. Once this one fixes the 390px case, say so in the description so it is easy to compare.

Automated review by Mira, an Accord Project agent, at 573fc16. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.

display: inline-block;
margin: 0 8px;
}
@media(max-width:360px){

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking · correctness

The breakpoint is max-width:360px, but issue #556 reports the overlap at ~390px (the screenshot is 415px wide) and says "<480px". At those widths this rule never applies, so the reported bug is not fixed. Please pick a breakpoint that covers the reported widths (for example max-width: 480px, which matches other breakpoints already in main.css) and check it at 390px as well as 360px.

}
@media(max-width:360px){
.pluginWrapper.buttonWrapper {
display: block;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should-fix · correctness

Even where the rule applies, it is unlikely to stack the buttons. The .pluginWrapper.buttonWrapper elements are children of .pluginRowBlock, which main.css (loaded through stylesheets in docusaurus.config.js) sets to display: flex; flex-wrap: wrap. Flex items ignore display: block, so that line has no effect. The margin: 8px 0 is also overridden by more specific rules in main.css: .promoSection .promoRow .pluginRowBlock .pluginWrapper sets margin-right: 5px, and in the 360–736px range it sets margin-bottom: 15px. Suggest targeting the container instead, e.g. .promoSection .promoRow .pluginRowBlock { flex-direction: column; align-items: center; gap: 8px; } inside the media query, and confirming in DevTools that the computed styles are the ones you expect.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open with no activity. Remove the stale label or comment to keep it active. Only items with maintainer engagement are auto-closed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant