Repository navigation
Side effects on locale and timezone when importing extractcode.libarchive2 as library #65
Description
Importing extractcode.libarchive2 has unexpected side effects on the caller, especially when used as a library inside a larger project.
In my specific case, the base application is running with the Europe/Berlin timezone, as this is my local time. After having executed some extraction code involving the aforementioned module, my timezone is set to UTC. This only became obvious because my logging showed that processing the archive finished nearly two hours before starting the process.
The reason is
extractcode/src/extractcode/libarchive2.py
Lines 135 to 143 in db9dd08
Edit: It seems like these aspects are not covered by unit tests as well, which makes evaluating alternatives or removing these lines harder.
Activity
[-]Side effects when importing `extractcode.libarchive2` as library[/-][+]Side effects on locale and timezone when importing `extractcode.libarchive2` as library[/+]pombredanne commentedon Nov 11, 2024
Thanks. This is unfortunate as setting the UTC timezone was done to get a better time from archives across test runners at least. We should avoid this but I still may want that at least for tests? Outside of tests, this may be less critical