Skip to content
This repository was archived by the owner on Aug 10, 2026. It is now read-only.

DOC-412: Update NodeJS code samples for the quickstart - #1169

Merged
m-hulbert merged 1 commit into
fea-1041-update-quickstartfrom
doc-412-update-node-quickstart
Aug 13, 2021
Merged

m-hulbert merged 1 commit into
fea-1041-update-quickstartfrom
doc-412-update-node-quickstart

Conversation

@m-hulbert

@m-hulbert m-hulbert commented Aug 12, 2021 •

Copy link
Copy Markdown
Contributor

NOTE TO REVIEWERS - please do not review PRs in the DRAFT state, as the PR may change substantially before it is ready to review. Thanks.

Description

This PR updates and fixes the code examples for Node JS in the quickstart. See JIRA for further information.

Review

To review, visit the quickstart page and view it in Node.

@m-hulbert m-hulbert added the DRAFT Draft PR - do not review label Aug 12, 2021
@m-hulbert
m-hulbert requested a review from marklewin August 12, 2021 10:27
@m-hulbert m-hulbert self-assigned this Aug 12, 2021
@mattheworiordan
mattheworiordan temporarily deployed to ably-docs-pr-1169 August 12, 2021 10:28 Inactive
@kennethkalmer
kennethkalmer temporarily deployed to ably-docs-pr-1169 August 12, 2021 14:21 Inactive

@marklewin marklewin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-hulbert m-hulbert removed the DRAFT Draft PR - do not review label Aug 13, 2021
@m-hulbert
m-hulbert marked this pull request as ready for review August 13, 2021 12:20
@m-hulbert
m-hulbert merged commit 3aead09 into fea-1041-update-quickstart Aug 13, 2021
@m-hulbert
m-hulbert deleted the doc-412-update-node-quickstart branch August 13, 2021 12:20

This branch was previously deployed

1 inactive deployment
ably-docs-pr-1169 — 362c0d8a Deployed Aug 12, 2021 by kennethkalmer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants