Repository navigation
test: install HTTP dependencies for the legacy cross-version server - #1320
Merged
Iwaniukooo11 merged 2 commits intoOct 12, 2026
Merged
Conversation
8 tasks done
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/cluster/database_event_stream.py | 96.94% | 92.86% | 🔴 -4.08% |
| Total | 93.14% | 93.10% | 🔴 -0.04% |
Generated by coverage-comment.yml
Iwaniukooo11
approved these changes
Oct 12, 2026
Iwaniukooo11
enabled auto-merge (squash)
October 12, 2026 12:13
Contributor
Author
|
Thanks @Iwaniukooo11 for reviewing and merging this, and thanks to the maintainers for the cross-version CI coverage. Glad the legacy test-server dependency fix is now in main. |
ishymko
added a commit
that referenced
this pull request
Oct 19, 2026
The cross-version tests start the 0.3.24 client and server with `uv run --no-project --with ...`. With `--no-project`, uv still builds the `--with` environment on top of the project's .venv. The legacy processes can then import packages from the dev group, which includes a2a-sdk[all]. Because of this, the 0.3 server started in CI without its `http-server` extra and the tests passed. They failed only on machines where .venv did not have sse-starlette (fixed in #1320). Add `--isolated` so that each legacy environment uses a bare interpreter and contains only the dependencies it declares.
ishymko
added a commit
that referenced
this pull request
Oct 19, 2026
The cross-version tests start the 0.3.24 client and server with `uv run --no-project --with ...`. With `--no-project`, uv still builds the `--with` environment on top of the project's .venv. The legacy processes can then import packages from the dev group, which includes a2a-sdk[all]. Because of this, the 0.3 server started in CI without its `http-server` extra and the tests passed. They failed only on machines where .venv did not have sse-starlette (fixed in #1320). Add `--isolated` so that each legacy environment uses a bare interpreter and contains only the dependencies it declares.
Iwaniukooo11
pushed a commit
that referenced
this pull request
Oct 20, 2026
The cross-version tests start the 0.3.24 client and server with `uv run --no-project --with ...`. With `--no-project`, uv still builds the `--with` environment on top of the project's .venv. The legacy processes can then import packages from the dev group, which includes a2a-sdk[all]. Because of this, the 0.3 server started in CI without its `http-server` extra and the tests passed. They failed only on machines where .venv did not have sse-starlette (fixed in #1320). Add `--isolated` so that each legacy environment uses a bare interpreter and contains only the dependencies it declares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cross-version fixture starts the 0.3.24 FastAPI/JSON-RPC server in an isolated
uv --no-projectenvironment, but requests onlya2a-sdk[grpc]. That environment lackssse-starlette, so server startup raisesImportErrorand all four cross-version combinations fail during setup.Request
a2a-sdk[grpc,http-server]==0.3.24for that server. This changes one test dependency declaration; the client environments and SDK runtime dependencies stay as they are.Validation on main
e11cb3e55dd536bee99fe185723db3c8ff6f8a13, Python 3.12.11:Before: four cross-version setup errors; the legacy server reports the missing HTTP-server packages.
After:
./scripts/lint.shexits 0;uv run pytest --timeout=45reports 2243 passed, 183 skipped, 3 xfailed, 1 xpassed. All four cross-version combinations pass.git diff --checkpasses. Skipped coverage includes external PostgreSQL/MySQL services; they were not configured locally. The existing expected-failure markers reference [Feat]: Improve server concurrency architecture #869.Followed the contribution guide and conventional-commit title format.
Tests and linter pass.
Documentation changes are not needed for this test-environment dependency.
AI-assisted investigation and validation with Codex for Mission.