Repository navigation
Fix plain-text mentions, channel user list events, friend requests without notifications, queue party limits and running captions - #927
Open
moss-orbit-9f339e wants to merge 4 commits into
Conversation
…dact only when shown - iAmMentioned used string.find with the user name as a pattern, so a name with brackets or other magic characters (for example [ABC]Alice) did not match, and could match other text. Use a plain find. - OnJoined, OnLeft and OnClients updated the user list of the current tab for events of any channel. Check the channel name. - The debug console listeners redacted each command also when the debug console was off. Found by a Codex audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AddFriendRequest was inside the AllowNotification() block, so with notifications off the request did not appear in the list. Found by a Codex audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UpdateQueueInformation ignored newMaxPartySize, so the join button kept the old party size limit until the window was made again. While the party is in the queue, the Leave button now stays visible also when the party is larger than the limit (before, both buttons were hidden and the party could not leave the queue from this panel). Found by a Codex audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The game caption shows the running state and time, but it was updated only by OnUpdateBattleInfo, not when the battle started or stopped or on the timer tick, so it could show the old state. Found by a Codex audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes in lobby UI components. Each commit fixes one file.
iAmMentionedusedstring.findwith the user name as a pattern, so a name with brackets or other magic characters (for example[ABC]Alice) did not match, and could match other text. It is now a plain find.OnJoined,OnLeftandOnClientsupdated the user list of the current tab for events of any channel. They now check the channel name.AddFriendRequestwas inside theAllowNotification()block, so with notifications off the request did not appear in the list.UpdateQueueInformationignorednewMaxPartySize, so the join button kept the old party size limit. While the party is in the queue, the Leave button now stays visible also when the party is larger than the limit (before, both buttons were hidden).OnUpdateBattleInfo, not when a battle started or stopped or on the timer tick.Testing (Windows, RTX 3080, engine 2026.09.01-17-gad28d7b)
e0b6e2feand this branch: both log only the samedebugfunctions.luaload error. There are no new errors.luac5.1 -p. The chat, friend, queue and battle list paths need an online lobby; I did not test them in a lobby. A second reviewer checked each commit, with mocked calls for the queue panel.AI disclosure: OpenAI Codex (GPT-6.1 Sol) found these bugs in a code audit; a second Codex review checked the branch. Claude Code checked each finding against the code, changed or left out the fixes it was not sure about, and ran the tests.
🤖 Generated with Claude Code