Repository navigation
Lock Octokit dependencies for publish notifications - #245
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Freeze the Octokit dependency graph used by the publish notification job and install it with
npm ci --ignore-scripts. The committed lock records exact versions and integrity hashes for the existing manifest ranges.Evidence
npm cirejects the directory because no lockfile exists; the workflow usesnpm iand resolves floating dependencies before importing them in a credential-bearing step.npm auditreports no known advisories for the locked graph.Risk
The notification job now fails if its manifest and lock disagree or if downloaded content fails integrity checks. Its existing upstream checkout must contain the lock before the changed install command can succeed.
Unverified
GitHub-hosted execution, the shell step's hosted Node/npm versions, live App authentication, dispatch and Sonar reanalysis were not run. No Python SDK source changed, so SDK tests were not run.