Skip to content

to_dict generates non serializable object because of enums #93

Open
Open
to_dict generates non serializable object because of enums#93
Assignees
RettBehrens

Description

@farfanoide
farfanoide
opened on Jun 26, 2022

using Xero-python 1.8 on python 3.10.4 trying to convert a Journal to dictionary using to_dict method.

I expect to have a json serializable dict of primitive values however I get an AccountType enum which is not serializable.
simple enough to have a custom encoder that handles enums but it would also be rather simple to extend the serializer process here to enable proper conversion.

adding following code to models.py fixes the issue:

from enum import Enum
@serialize_to_dict.register(Enum)
def serialize_enum_to_dict(value):
    return value.value

please let me know if a pr is welcome for this or if further information is required.

Activity

  1. mseflek commented on Oct 3, 2022

    @mseflek
    mseflek
    on Oct 3, 2022

    bumping this issue as I'm having the same problem.

  2. RettBehrens
    self-assigned this
    on Oct 4, 2022

  3. farfanoide commented on Oct 4, 2022

    @farfanoide
    farfanoide
    on Oct 4, 2022
    Author

    Enum issue was solved for me by upgrading to xero-python==1.16.0 however note that this introduced different errors for UUID and None

    from xero_python.api_client.serializer import serialize_model

@serialize_model.register(UUID)
def serialize_uuid_model(model):
    """Serializes api model into an json serializable object.

    :param model: BaseModel instance to serialize
    :return: serialized object
    """
    return model.hex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions