Critical error on LLC business structures #213

Activity

1. github-actions commented on Mar 31, 2026

   

   github-actionsBot

   on Mar 31, 2026 – with GitHub Actions

   More actions

   PETOSS-924
2. github-actions commented on Mar 31, 2026

   

   github-actionsBot

   on Mar 31, 2026 – with GitHub Actions

   More actions

   Thanks for raising an issue, a ticket has been created to track your request
3. CedricConday commented on Jul 2, 2026

   

   CedricConday

   on Jul 2, 2026

   More actions

   Same root cause as #203/#205/#206 — the SDK's hardcoded allowed_values rejects an enum value the Xero API legitimately returns, raising ValueError while deserializing an otherwise-valid response.

   My open PR #231 makes deserialize_model tolerant of exactly this: it tries the normal validating construction first and only on ValueError falls back to preserving the raw value — so an org with organisation_entity_type = SINGLEMEMBERLLC (or any future unknown enum) deserializes instead of crashing, which resolves the "critical error" generically.

   Adding the LLC values (CCORPORATIONLLC, PARTNERSHIPLLC, SCORPORATIONLLC, SINGLEMEMBERLLC, UNSPECIFIED) to allowed_values is still worth doing as the complementary "make them first-class" fix — the two are orthogonal (tolerance prevents crashes; the enum list makes the values official). Happy to fold a regression test for the LLC case into #231 if that's useful.