Add ability to provide retry options that are passed into urllib3 #199

Activity

1. github-actions commented on Aug 8, 2025

   

   github-actionsBot

   on Aug 8, 2025 – with GitHub Actions

   More actions

   PETOSS-808
2. github-actions commented on Aug 8, 2025

   

   github-actionsBot

   on Aug 8, 2025 – with GitHub Actions

   More actions

   Thanks for raising an issue, a ticket has been created to track your request
3. timrichardson commented on Aug 10, 2025

   

   timrichardson

   on Aug 10, 2025

   More actions

   +1 I am overriding ApiClient and AccountingApi to achieve this because monkey patching is not working. Being stuck in sleep_for_retry() for ten hours is not nice.
4. uptickmetachu commented on Sep 22, 2025

   

   uptickmetachu

   on Sep 22, 2025

   Last edited by uptickmetachu

   More actions

   urllib3/urllib3#3233

   Note this is also an open issue in urllib3. Until this is merged (who knows when); all users of this library suffer from an hours long sleep which can break many background processes.

   I would consider this a bug in the API client.

   Monkey patch on urllib3 to disable this sleep_for_retry if it is excessively long.

   import datetime
   from typing import Any
   
   from urllib3.util.retry import Retry
   
   original_sleep_for_retry = Retry.sleep_for_retry
   
   
   MAX_RETRY_AFTER = datetime.timedelta(minutes=10).seconds
   
   
   def _patched_sleep_for_retry(self, response: Any) -> bool:
       retry_after = self.get_retry_after(response)
       if retry_after > MAX_RETRY_AFTER:
           return False
       return original_sleep_for_retry(self, response)
   
   
   Retry.sleep_for_retry = _patched_sleep_for_retry