Repository navigation
feat(chart): add extraEnv, extraEnvFrom, extraVolumes, extraVolumeMounts and Redis init container - #1
Open
gsvitak-workwave wants to merge 1 commit into
Open
gsvitak-workwave wants to merge 1 commit into
gsvitak-workwave wants to merge 1 commit into
Conversation
…nts and Redis init container Add four extension points to all 5 Deployments and 3 CronJobs: - extraEnv: individual env vars or secretKeyRef entries - extraEnvFrom: bulk Secret/ConfigMap injection (e.g., ESO-managed secrets) - extraVolumes: additional pod volumes - extraVolumeMounts: additional container volume mounts All default to empty lists and emit nothing when unset. Also wire the existing openmeter.init.redis helper into all Deployments and CronJobs so pods wait for Redis readiness alongside PostgreSQL and ClickHouse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gsvitak-workwave
force-pushed
the
feat/chart-secrets-extension-points
branch
from
August 21, 2026 17:37
3ec7c1b to
c08ffc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add four extension points to all 5 Deployments and 3 CronJobs in the OpenMeter Helm chart:
extraEnv— individual env vars orsecretKeyRefentriesextraEnvFrom— bulk Secret/ConfigMap injection (e.g., ESO-managed secrets)extraVolumes— additional pod volumesextraVolumeMounts— additional container volume mountsAll default to empty lists and emit nothing when unset.
Also wires the existing
openmeter.init.redishelper into all Deployments and CronJobs so pods wait for Redis readiness alongside PostgreSQL and ClickHouse.Motivation
Enables safe secret injection via External Secrets Operator (or any secrets backend) through native Helm values, removing the need for brittle JSON6902 patches that break when upstream chart structure changes.
Example usage
Changes
values.yaml— 4 new top-level fields with helm-docs comments and usage examplestemplates/deployment.yaml— extension points added to all 5 Deployments + Redis init containertemplates/jobs.yaml— extension points added to all 3 CronJobs + Redis init container🤖 Generated with Claude Code