Skip to content

add skipping for missing spells + replace fixed timers with server response - #2591

Open
ianandersonlol wants to merge 2 commits into
Windower:devfrom
ianandersonlol:azuresets-1.26
Open

ianandersonlol wants to merge 2 commits into
Windower:devfrom
ianandersonlol:azuresets-1.26

Conversation

@ianandersonlol

Copy link
Copy Markdown
Contributor

I didn't like that azuresets would just stop but act complete when a spell was missing. I have multiple characters with different levels of spell completion, but I would still like to use the same azureset template. I also noticed that when things were lagging the 0.65 set timer wouldn't fire, so it now waits for the server's response before moving on, plus some jitter which can be turned off.

I've found in testing it sets slightly faster, but other optimizations make it significantly faster. Instead of removing a spell and then setting the new one, it now swaps the new spell straight into the old spell's slot, so a swap that took 20 changes now takes 12. It also skips clearing with ClearFirst if your spells are already empty, and doesn't re-run a set you already have on just because it has spells you're missing.

I also added //aset stop and //aset check. I didn't like that if I changed my mind midway through, both sets ran at the same time, which spammed the server and would mess up the sets, so starting a set now takes over from one that's still running.

…sponse

Spells that can't be set are skipped instead of stopping the set, + optimizations for setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant