Repository navigation
add skipping for missing spells + replace fixed timers with server response - #2591
Open
ianandersonlol wants to merge 2 commits into
Open
ianandersonlol wants to merge 2 commits into
ianandersonlol wants to merge 2 commits into
Conversation
…sponse Spells that can't be set are skipped instead of stopping the set, + optimizations for setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't like that azuresets would just stop but act complete when a spell was missing. I have multiple characters with different levels of spell completion, but I would still like to use the same azureset template. I also noticed that when things were lagging the 0.65 set timer wouldn't fire, so it now waits for the server's response before moving on, plus some jitter which can be turned off.
I've found in testing it sets slightly faster, but other optimizations make it significantly faster. Instead of removing a spell and then setting the new one, it now swaps the new spell straight into the old spell's slot, so a swap that took 20 changes now takes 12. It also skips clearing with ClearFirst if your spells are already empty, and doesn't re-run a set you already have on just because it has spells you're missing.
I also added
//aset stopand//aset check. I didn't like that if I changed my mind midway through, both sets ran at the same time, which spammed the server and would mess up the sets, so starting a set now takes over from one that's still running.