Repository navigation
[GearSwap] Use coroutine scheduler to do delayed casts - #2587
Merged
Merged
Conversation
GearSwap currently uses a bit of a hacky method to do delayed casts that relies on the console wait command, which also introduces an additional code path with the pretarget_delayed_cast and precast_delayed_cast functions. This commit switches to using the more proper, robust method of the coroutine scheduler which also ensures all casts, delayed or not, take the identical code path.
Contributor
|
@z16 I think you were poking at the scheduler right? Are you happy with its current state? |
Member
|
Yes. There are currently no known scheduler issues. Maybe this will help us discover some. |
Contributor
The dr. House method of finding bugs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GearSwap currently uses a bit of a hacky method to do delayed casts that relies on the console wait command, which also introduces an additional code path with the pretarget_delayed_cast and precast_delayed_cast functions. This commit switches to using the more proper, robust method of the coroutine scheduler which also ensures all casts, delayed or not, take the identical code path.