Skip to content

[Addon] [findAll] Server-specific files #2313

Open

Description

@Byrth

Right now findAll dumps inventory data into findAll/data/${character_name}.lua. However, it is possible for players to have the same character name on two servers.

It should instead use both server_name and character_name in the path or filename.

Pretty trivial change (windower.ffxi.get_info()['server'] + resources.servers to translate it), but it would invalidate existing files for people.

Activity

  1. Nifim commented on Aug 28, 2023

    @Nifim
    Contributor

    You could add a fall back to the original path, in the event findAll/data/${server_name}_${character_name}.lua does not exist look for findAll/data/${character_name}.lua and then only save to the new path.

  2. RubenatorX commented on Aug 28, 2023

    @RubenatorX
    Collaborator

    Pretty trivial change (windower.ffxi.get_info()['server'] + resources.servers to translate it), but it would invalidate existing files for people.

    This approach will cause errors on private servers without additional consideration (specifically that, on a private server, windower.ffxi.get_info()['server'] would typically return nil, so make sure to handle that case)

  3. lili-ffxi commented on Sep 5, 2023

    @lili-ffxi
    Contributor

    Keeping it private-server friendly, and backwards compatible, would just be a matter of making it fallback to Charactername.lua if Server_Charactername.lua is not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions