Skip to content

Treasury Passing Rare/EX item when not on list #2088

Open

Description

@Chiaia

Logging this down so we don't forget about it.
Thorny
"so, looking at treasury source

it has the same problem itemtools(?) or whatever atom0s original lot/pass addon had in ashita1 10 years ago

it passes as a reaction to the incoming item packet

but, passing and lotting are tied to index within treasure pool, not an item id

so, take an example circumstance:
-you have 6 RA, EX, or RA/EX items in pool, occupying indices 0-5

you get a new pool of 8 items, the first 4 are NOT rare or ex

those 4 get assigned to indices 6, 7, 8, 9

now, say the first of those items is on pass, treasury will queue a pass packet on slot 6

but, the next 4 packets to come in replace indices 6, 7, 8, and 9 again because non-rare, non-ex items are replaced before rare or EX items

so despite the pool instantly sorting the first 4 items of your 8 item drop, windower is still reacting on those slots based on prequeued responses

your regal gauntlets drop into indice 6 and get passed reliably on both characters

i solved it by storing which item is in each of the 10 indices, and then on outgoing chunk i insert the response in the same outgoing chunk, so that it's using the actual state of the treasure pool at the time the chunk goes out, rather than responding on a single incoming packet basis"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions