[gnzlbg]

This makes it clear everywhere that ImmLaneIdx is an immediate operand and also makes the nomenclature for immediate operands consistent (both ImmByte and ImmLaneIdx start with the prefix Imm) .

See #33 .

[gnzlbg]

So now I think this PR is incorrect, since some instructions like extract_lanes do not appear to require immediate mode operands (or at least the spec doesn't say so). I am re-opening the issue #33 .

[gnzlbg]

So looking at the binary encoding it appears that the extract_lanes / replace_lanes / ... all take immediate mode operands... so I think this PR is correct, but incomplete, in that the nomenclature should be made consistent for those other operations as well.

[gnzlbg]

So I've pushed another commit with new changes that:

• consistently prefix immediate mode arguments with imm
• consistently describes how these immediate mode arguments are encoded in the binary
• contains a text-form explanation of the semantics of the shuffle instruction indices
• contains further explanations and examples of what the interpretation and the hierarchy are since they are only a naming scheme for instructions.

[binji]

This looks like a good clarification, thanks! When this is converted to formal spec text it will be less of an issue because the immediate args vs. stack args are specified separately. See for example set_local: https://webassembly.github.io/spec/core/exec/instructions.html#exec-set-local. The x is immediate and the expected stack structure is specified in the associated validation section.

[gnzlbg]

@penzn

I don't know why the wording in the spec is the way it is, but you can definitely try submitting a PR to correct it :)

I've got your back :P

[penzn]

@penzn

I don't know why the wording in the spec is the way it is, but you can definitely try submitting a PR to correct it :)

I've got your back :P

I see, I should've noticed that you already opened it :)

[gnzlbg]

Thank you for your feedback @dtig , I hope I incorporated all of it correctly into the PR, let me know what you think!

[dtig]

Thanks for incorporating feedback!