This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Rename integer-to-integer widening instructions to "extend"? #467
Description
Referring to this section https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#integer-to-integer-widening, was there a reason why we chose "widen"? That isn't a terminology used in the current Wasm spec, it uses "extend" (e.g. see https://webassembly.github.io/spec/core/appendix/index-instructions.html).
Can we change the names to extend? (Everything else stays the same, only s/widen/extend/.
Reacted by Thomas Lively
Activity
tlively commentedon Feb 16, 2021
SGTM
zeux commentedon Feb 17, 2021
If we switch from
widentoextend, what do we do withnarrow? Doesn't look like scalar spec has an equivalent.tlively commentedon Feb 17, 2021
The scalar spec has
i32.wrap_i64, butwrapisn't great for the SIMD version because it saturates rather than wrapping :/ngzhian commentedon Feb 17, 2021
We can keep narrow since there is no equivalent instruction in scalar spec.
tlively commentedon Feb 19, 2021
There were no strong objections to this renaming at today's meeting. @ngzhian, do you want to put a PR together?
[spectext] Rename integer widen instructions to integer extend
[spectext] Rename integer widen instructions to integer extend
[interpreter] Rename integer widen instructions to integer extend
[interpreter] Rename integer widen instructions to integer extend
fix(simd): update SIMD opcodes
fix(simd): update SIMD opcodes
fix(simd): update SIMD opcodes
fix(simd): update SIMD opcodes