This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 3, 2021. It is now read-only.
[js-api] ToWebAssemblyValue signature change #51
Description
In #8, ToWebAssemblyValue gained an additional error argument; the current spec only passes it in a single call site. It seems like it had a caller that passed LinkError at the time. Presumably all callers should pass a value here; otherwise the argument should be marked as optional.
Alternatively, the algorithm should always throw a TypeError; that's what it already throws when ToInt32 and friends fail.
Activity
Remove the intermediate buffer for memory.copy (#51)
[js-api] Remove spurious argument to ToWebAssemblyValue().
ioannad commentedon Feb 17, 2020
I also think that the 3rd (error) argument of
ToWebAssemblyValuecan be safely removed, since there is noLinkErrorto propagate anymore. If such an error propagation is needed in the future, I would also go for an optional third argument.[js-api] Remove spurious argument to ToWebAssemblyValue().