Repository navigation
[Wasm GC] Optimize RefCast + ignore-implicit-traps - #3748
Merged
Merged
Conversation
tlively
approved these changes
Mar 30, 2021
Comment on lines
+6
to
+8
| (type $A (struct (field i32))) | ||
| (type $B (struct (field i32) (field f64))) | ||
| (type $C (struct (field i64) (field f32))) |
Member
There was a problem hiding this comment.
How about parent, child, and other rather than A, B, and C?
Comment on lines
+108
to
+114
| (param $a (ref $A)) | ||
| (param $b (ref $B)) | ||
| (param $c (ref $C)) | ||
|
|
||
| (param $a-rtt (rtt $A)) | ||
| (param $b-rtt (rtt $B)) | ||
| (param $c-rtt (rtt $C)) |
Member
There was a problem hiding this comment.
It looks like this only uses $a and $a-rtt. Removing the extra params would make the test output shorter.
martianboy
pushed a commit
to martianboy/binaryen
that referenced
this pull request
Mar 31, 2021
If we are ignoring implicit traps, and if the cast is from a subtype to a supertype, then we ignore the possible RTT-related inconsistency and can just drop the cast. See WebAssembly#3636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are ignoring implicit traps, and if the cast is from a subtype to a supertype,
then we ignore the possible RTT-related inconsistency and can just drop the
cast.
See #3636
cc @askeksa-google