Repository navigation
Conversation
tlively
reviewed
Mar 2, 2021
| } | ||
| if ((!child->type.isRef() && !child->type.isRtt()) || | ||
| child->type.getHeapType() != heapType) { | ||
| !HeapType::isSubType(child->type.getHeapType(), heapType)) { |
Member
There was a problem hiding this comment.
Could this function be deduplicated to parsing.h? The Element argument could become an optional pointer.
Member
Author
There was a problem hiding this comment.
It almost can, but the mechanisms they use to throw are also different, which is why this wasn't deduplicated before.
A larger refactoring to unify how they throw might make sense I think.
Member
There was a problem hiding this comment.
ahhh, I missed that difference. Refactoring at some point makes sense to me, but definitely not urgent 👍
tlively
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that Binaryen "canonicalizes" the type, so in the test output here
we end up with
$grandchildtwice. This is a consequence of us notstoring the heap type as an extra field. I can't think of a downside to
this canonicalization, aside from losing perfect roundtripping, but I think
that's a worthwhile tradeoff for efficiency as we've been thinking so far?
Fixes #3636