Repository navigation
Switch warnings no longer work #2572
Description
See discussion in #2451 (comment)
IIUC the issue is that we cast those class instances to an int, and the warnings don't work for ints.
Maybe there's another way? Or, if we don't want these warnings anymore, perhaps we can remove unnecessary cases from switches?
Activity
tlively commentedon Jan 7, 2020
This is an issue both before and after #2434, but that PR brings it closer to being fixed.
The compiler feature that warns about non-exhaustive switches on enums only works when the type being switched on is that enum. But since #2459, switching on types has worked because the following automatic conversion is defined for
Type:So the type actually being switched on is
uint32_t. I just did a little experiment locally and it looks like switching the conversion operator to returnValueTyperather thanuint32_tin conjunction with #2434 will solve this problem. The question is then what to do about multivalue types, which don't correspond to anyValueType. I suppose the most robust thing to do would be to assert that the value is not a multivalue in the conversion operator. Multivalue types can't participate in switches anyway because their IDs are notconstexpr.Make compiler complain about non-exhaustive type switches again
Remove implicit conversion operators from Type
Use TYPE_SWITCH macro for types (NFC)
Remove implicit conversion operators from Type (#2577)