This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Repository navigation
trickleICE Config + RtcommService state inconsistencies - #17
Merged
Merged
Conversation
jfmartinez
commented
Feb 18, 2016
jfmartinez
commented
Contributor
- Added the configuration option for trickleICE (also included the changes done on the master branch for the webRTC Config)
- There were inconsistent state issues:
- When the EndpointProvider gets a reset event it actually destroys itself, added the flag to reflect the changes in the RtcommService
- When Unregistering and a session was in place, sometimes the endpoint was already destroyed and calling .destroy() on it caused an error and the service to crash, now it checks if it is undefined before calling destroy
- Added a new state 'session:connecting' which occurs when between inbound request acceptance and the session:started event. (This is to handle the long wait when trickleICE is false)
* develop: useSSL settings no longer required Update version to v1.0.3 Remove useSSL, rtcomm will pick it if https Register fix Enhanced the rtcomm-register, session:alerting displayed on inbound calls fixed, alert modals can't be closed by clicking on backdrop
…dcast settings, setting the configuration for the service also reset the ringtone values to null ~ fixed as well
RtcommService setConfig hotfix
…to an issue when you unregister the endpoint, destroying the endpoint returns undefined/causes an inconsistent state, also added a new state for the rtcomm-endpoint for when it is in between ringing and connected.
…commService wasn't capturing this event, now it will mark as uninitialized
jfmartinez
added a commit
that referenced
this pull request
Mar 2, 2016
trickleICE Config + RtcommService state inconsistencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.