Repository navigation
fix(resource): support headless update and delete - #105
Open
hamadalmunyif wants to merge 3 commits into
Open
hamadalmunyif wants to merge 3 commits into
hamadalmunyif wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
acp resource createalready supports explicit flags, butresource updateandresource deletestill require interactive selection. This blocks scripted, CI, and other headless resource lifecycle management.Fixes #79.
What
--resource-idtoresource updateandresource delete.--forceto delete so scripted deletion does not prompt.README.mdandSKILL.md.The implementation follows the existing non-interactive patterns used by offering and subscription management and adds no dependencies.
Validation
Validated on the fork with Node 22:
npm install --ignore-scriptsnpm run typechecknpm run buildAll three completed successfully.
Note: a fresh
npm cion the unmodified upstream baseline currently reports the lockfile as out of sync (utf-8-validate@5.0.10missing). This PR does not modify dependencies or the lockfile.Note
Low Risk
CLI-only changes to resource lifecycle commands with preserved interactive defaults; no auth, payment, or API contract changes.
Overview
Adds non-interactive paths for
acp resource updateandacp resource delete, matching offerings and subscriptions so CI and scripts can manage resources without prompts.Update:
--resource-idselects the resource; optional--name,--description,--url,--params, and--hidden/--no-hiddenapply partial changes (omitted fields stay unchanged). With--resource-id, updates come only from flags—no readline prompts.Delete:
--resource-idtargets a resource;--forceskips the confirmation prompt.Interactive behavior is unchanged when
--resource-idis omitted. README.md and SKILL.md document the new flag-based examples.Reviewed by Cursor Bugbot for commit 5526b60. Bugbot is set up for automated code reviews on this repo. Configure here.