Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed API-key providers without declared or catalog icons currently fall back to a generic package symbol even when they declare a public credential host. Use a single exact public host for the existing favicon fallback, preserving declared icons, catalog icons and OAuth precedence. Private suffixes, IP addresses, wildcards and ambiguous host lists keep the neutral fallback; only the registrable domain reaches the logo proxy.
Validation:
bun run checkand two self-host browser scenarios passed (provider fallback and declared light/dark app icons). The new fallback scenario also failed with the fallback removed, then passed after restoring it. Cloud and local target scenarios were not executed locally.