Repository navigation
Conversation
jossephus
force-pushed
the
fix/self-host-forwarded-proto
branch
from
October 14, 2026 06:07
c101be2 to
ac7fa59
Compare
The Go host proxies to workerd over plain http, and ReverseProxy's Rewrite drops X-Forwarded-Proto, so the product saw http:// request URLs even when browsers used https://. The dashboard batch endpoint compares Origin with that URL, so behind an HTTPS proxy every POST /api/dashboard/batch answered 403 and dashboard panels showed "Unable to complete this request". The Go host now passes the proxy's X-Forwarded-Proto (http or https) through.
jossephus
force-pushed
the
fix/self-host-forwarded-proto
branch
from
October 14, 2026 06:09
ac7fa59 to
8baa0fc
Compare
Author
Collaborator
|
Thanks @jossephus for the report and the ping. The fix from #2250 is on main now, with you credited as a co-author. It ships in the next beta image, which I'm cutting now. Sent from my Claude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behind an HTTPS reverse proxy, every
POST /api/dashboard/batchon self-host answers an empty403and dashboard panels show "Unable to complete this request" (#2199). Reproduced on2.0.0-beta.17behind Caddy: 26 of 26 batch requests refused in an hour, all same-origin.The Go host proxies to workerd over plain http, and
ReverseProxy'sRewritedrops the outer proxy'sX-Forwarded-Proto, so the product rebuildshttp://<host>andsameOrigininbatch-host.tsrefuses the browser'shttps://Origin.This passes the proxy's
X-Forwarded-Proto(httporhttps) through to the product, instead of deriving the scheme fromBETTER_AUTH_URLas #2251 does.go vetandgo test ./...inapps/hosted/self-host/nativepass.