Repository navigation
fix(dashboard): accept https Origin behind a TLS-terminating proxy - #2273
Open
The-AarushiSingh wants to merge 2 commits into
Open
The-AarushiSingh wants to merge 2 commits into
The-AarushiSingh wants to merge 2 commits into
Conversation
The-AarushiSingh
marked this pull request as ready for review
October 12, 2026 16:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2272
Behind a TLS-terminating proxy the container sees http:// while the browser sends Origin: https://, so sameOrigin never matched and every batch POST returned 403.
When X-Forwarded-Proto is https, the origin is compared as https://…. Host check and application/json requirement are unchanged.
Tests added:
proxied origin + header → accepted
same origin without header → still 403
foreign host + header → still 403
Reproduced on Railway self-host: every POST /api/dashboard/batch returned 403 while the rest of the dashboard worked.