Skip to content

Fix the ordering of initializing lut due to change in mpl version #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 4 commits into from
Oct 21, 2026
Merged

Fix the ordering of initializing lut due to change in mpl version #849

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daf5051
Fix the ordering of initializing lut due to change in mpl version
cvanelteren Oct 19, 2026
d4a3cc0
Ordering
cvanelteren Oct 19, 2026
22acb3d
Merge branch 'main' into fix/lut-init-order
cvanelteren Oct 21, 2026
de3679c
Merge branch 'main' into fix/lut-init-order
cvanelteren Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions ultraplot/colors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,13 +2084,19 @@ def _init(self):

# Make hues circular, set extremes i.e. copy HSL values
self._lut = self._lut_hsl.copy()
self._set_extremes() # generally just used end values in segmentdata
self._isinit = True

# Now convert values to RGB and clip colors
for i in range(self.N + 3):
# Convert the regular color entries to RGB
# Note: as of mpl 3.11 setting lut is not performed when
# updating set_extremes, as such there is an ordering effect
# here that we need to consider.
for i in range(self.N):
self._lut[i, :3] = to_rgb(self._lut[i, :3], self._space)
self._lut[:, :3] = _clip_colors(self._lut[:, :3], self._clip)
self._lut[: self.N, :3] = _clip_colors(self._lut[: self.N, :3], self._clip)

self._isinit = True
# Order here is important as
# mpl.3.11 only updates when init is set to true
self._set_extremes() # generally just used end values in segmentdata

@docstring._snippet_manager
def set_gamma(self, gamma=None, gamma1=None, gamma2=None):
Expand Down
Loading