Skip to content

Explicitly declare package data in pyproject.toml - #838

Merged
cvanelteren merged 3 commits into
Ultraplot:mainfrom
munechika-koyo:fix/explicit-package-data
Oct 21, 2026
Merged

cvanelteren merged 3 commits into
Ultraplot:mainfrom
munechika-koyo:fix/explicit-package-data

Conversation

@munechika-koyo

Copy link
Copy Markdown
Collaborator

The tool.setuptools.package-data configuration currently lists only py.typed.

Explicitly declare all required package data in pyproject.toml:

  • OpenCode goal files (.opencode/goals/**/*)
  • Colormaps (cmaps/*)
  • Named colors (colors/*)
  • Color cycles (cycles/*)
  • Fonts (fonts/*)

Retain py.typed to preserve the package's typing marker.
This makes package data inclusion explicit rather than relying solely on automatic file discovery.

Validation:

  • Built the sdist and a wheel from that sdist using pixi exec and python -m build --no-isolation with the declared build dependencies installed.
  • Verified that all 253 tracked files covered by these package-data entries, including all four OpenCode goal files and py.typed, are present in both archives.
  • git diff --check passed.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread pyproject.toml Outdated
[tool.setuptools.package-data]
ultraplot = ["py.typed"]
ultraplot = [
".opencode/goals/**/*",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed '.opencode/goals/**/*' from package data inclusion.
@cvanelteren
cvanelteren merged commit 0560f3f into Ultraplot:main Oct 21, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants