Repository navigation
fix(security): fix security issue in axios via major version upgrade from 0.27.2 to 1.20.0 in shared-actions - #275
Open
aikido-autofix[bot] wants to merge 1 commit into
Conversation
3 tasks
✅ Security Analysis ResultsNo security issues found. 2 files reviewed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: https://typeform.atlassian.net/browse/<TICKET_ID>
Upgrade axios to fix proxy bypass/SSRF, prototype pollution, credential leakage on redirects, and XSRF token exposure vulnerabilities.
Changes
✅ 9 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
X-API-Key) during cross-origin redirects, potentially leaking API keys and authentication tokens to unintended hosts. This information disclosure vulnerability affects shared environments where secret headers are set by default.//(e.g.,https:internal.example), allowing attackers to bypass URL allowlists or WAF checks and reach unintended hosts. The vulnerability enables URL validation bypass through silent normalization of invalid URLs.formDataToJSONfunction allows attackers to modify object prototypes. Additionally, a ReDoS vulnerability incombineURLscan cause denial of service through malicious input.🤖 Remediation details
Fix axios transitive vulnerability via resolutions override
Short summary
This PR remediates multiple high- and medium-severity vulnerabilities in the transitive dependency
axios(resolved at0.27.2, below the required fix floor of1.20.0). The fix is applied via aresolutionsentry inshared-actions/send-deployment-event/package.json, with the corresponding lockfile entry inshared-actions/send-deployment-event/yarn.lockupdated to reflect the new resolved version.axios
axios@0.27.2is pulled in transitively by the direct dependencyanalytics-node@6.2.0, which declaresaxios@^0.27.2— a range that cannot resolve to any 1.x release. Becauseanalytics-node@6.2.0is the only published version of that package, no parent bump path exists to admit a patchedaxios. Aresolutionsoverride ("axios": "1.20.0") was added toshared-actions/send-deployment-event/package.jsonas a last resort, forcing the lockfile to resolveaxiosto1.20.0— the minimum version that clears all identified advisories, including the additional CVEs (CVE-2026-101898 through CVE-2026-101909) requiring FixedVersion1.20.0that were surfaced during review.Version changes
axios0.27.21.20.0resolutionsoverride (parentanalytics-node@6.2.0cannot admit axios 1.x)Testing
Docs
For contributions to the
Typeform/.githubrepoNote: Please do not use this repository for new internal shared workflows and actions. Use https://github.com/Typeform/.github-private instead!
Please check that your contribution applies to one of these cases below. If this is not the case, please contribute to https://github.com/Typeform/.github-private instead.