Repository navigation
fix(bilibili): generate multi-quality DASH manifest representations for full resolution playback - #36
Conversation
…or full resolution playback
|
Thanks for the fix! Including all available resolutions in the manifest should restore the quality selector. One concern: Could you check this scenario and add a regression test? Ideally, a failed higher-quality stream should not prevent playback when a lower-quality stream is still available. The three manifest tests pass locally. I haven’t reproduced this failure in a browser yet. |
|
Good catch, thanks for pointing that out! I've updated the logic so each codec group now provides progressive resolution fallback slices (e.g.
|
|
Thanks for the update! All five tests pass locally now. Did you get a chance to try the fallback on your instance too, to see if playback actually resumes at a lower quality after an error? Unfortunately, I don’t have a BiliBili account to try it myself ;p |
|
Yep, tested it on my self-hosted setup! I simulated a failure by blocking/dropping the 1080p video URL. So the fallback path works nicely in practice without getting stuck. |
|
LGTM |
Summary
Fixes Bilibili playback being locked to 480p and restores the player's video quality selector by including all available stream resolutions in the generated DASH manifest.
Key Changes
DASH Manifest Multi-Resolution Support (bilibili-manifest.ts):
avc1>av01>hev1).<AdaptationSet>in descending resolution order (1080p, 720p, 480p, 360p), enabling Dash.js resolution switching and restoring the player quality menu.Manifest Unit Tests (apps/web/tests/bilibili-manifest.test.ts):