Skip to content

feat(UI): replace loading and error reactions with Tyme mascot - #138

Draft
Aquarius-Situla wants to merge 7 commits into
TypeType-Video:devfrom
Aquarius-Situla:feat/tyme-mascot
Draft

Aquarius-Situla wants to merge 7 commits into
TypeType-Video:devfrom
Aquarius-Situla:feat/tyme-mascot

Conversation

@Aquarius-Situla

@Aquarius-Situla Aquarius-Situla commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Replaces third-party loading and generic error reaction GIFs across the web client with original, MIT-licensed theme-aware Tyme mascot animations for light and dark modes, while keeping mid-playback buffering spinners unobtrusive.


Key Changes

Mascot Assets & Attribution Cleanup (apps/web/public/loading/, apps/web/public/fail/, reaction-gifs.ts, THIRD_PARTY_ASSETS.md, THIRD_PARTY_NOTICES.txt):

  • Added original Light and Dark Tyme animations for general/startup loading (normal/loading-{light,dark}.gif), landscape video loading (video/loading-{light,dark}.gif), portrait shorts loading (video/loading-vertical-{light,dark}.gif), and failure states (fail/fail-{light,dark}.gif).
  • Removed legacy third-party loading and generic error assets (loader-mascot.gif, loading-{1,2}.webp, video-error-{1..3}.webp, playback-error-{1..6}.webp) and pruned their notice entries while retaining contextual reaction GIFs and downloader-waiting.gif.

Mascot Components & Theme Helpers (loading-mascot.ts, fail-mascot.ts, player-loading-state.ts, use-resolved-theme.ts, use-player-loading-mascot.ts):

  • Added theme resolution hooks, player loading state helpers, and reusable components (TymeMascotCard, LoadingMascot, FailMascot, VidstackLoadingMascot).

Startup, Page & Player Integration (apps/web/index.html, VideoJsLoadingMascot, VidstackLoadingMascot):

  • Updated index.html asset preloading and #app-loader backdrop to render theme-matched startup Tyme loading animations.
  • Updated page, watch, shorts, embed, and Twitch stage loaders (PageSpinner, WatchLoadingIndicator, WatchPageSkeleton, WatchStage, EmbedLoading, ShortsShellLoader, ShortsPlayerStage, TwitchVideoView, TwitchWatchStage).
  • Configured both VidstackLoadingMascot and VideoJsLoadingMascot to display Tyme prior to the first frame, falling back cleanly to unobtrusive ring spinners (DefaultBufferingIndicator / .vds-buffering-spinner after a 400ms delay) for mid-playback buffering and timeline seeks.
  • Wired FailMascot into ChannelLoadError, StreamError, PlayerError, EmbedError, ShortsError, and VideoJsRecoveryCover.

Mascot Unit Tests (apps/web/tests/loading-mascot.test.ts, apps/web/tests/fail-mascot.test.ts, apps/web/tests/player-loading-state.test.ts, apps/web/tests/reaction-gifs.test.ts):

  • Added unit tests covering theme-matched mascot resolution, player loading/buffering state transitions, and updated reaction GIF registries.

@Aquarius-Situla
Aquarius-Situla marked this pull request as draft November 21, 2026 14:24
@Aquarius-Situla
Aquarius-Situla marked this pull request as ready for review November 21, 2026 15:15
@Aquarius-Situla
Aquarius-Situla marked this pull request as draft November 21, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant