Repository navigation
feat(UI): replace loading and error reactions with Tyme mascot - #138
Draft
Aquarius-Situla wants to merge 7 commits into
Draft
Aquarius-Situla wants to merge 7 commits into
Aquarius-Situla wants to merge 7 commits into
Conversation
Aquarius-Situla
marked this pull request as draft
November 21, 2026 14:24
Aquarius-Situla
force-pushed
the
feat/tyme-mascot
branch
from
November 21, 2026 14:45
d25067a to
ba1de2a
Compare
Aquarius-Situla
force-pushed
the
feat/tyme-mascot
branch
from
November 21, 2026 15:03
ba1de2a to
f6112a9
Compare
Aquarius-Situla
marked this pull request as ready for review
November 21, 2026 15:15
Aquarius-Situla
marked this pull request as draft
November 21, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces third-party loading and generic error reaction GIFs across the web client with original, MIT-licensed theme-aware Tyme mascot animations for light and dark modes, while keeping mid-playback buffering spinners unobtrusive.
Key Changes
Mascot Assets & Attribution Cleanup (apps/web/public/loading/, apps/web/public/fail/, reaction-gifs.ts, THIRD_PARTY_ASSETS.md, THIRD_PARTY_NOTICES.txt):
normal/loading-{light,dark}.gif), landscape video loading (video/loading-{light,dark}.gif), portrait shorts loading (video/loading-vertical-{light,dark}.gif), and failure states (fail/fail-{light,dark}.gif).loader-mascot.gif,loading-{1,2}.webp,video-error-{1..3}.webp,playback-error-{1..6}.webp) and pruned their notice entries while retaining contextual reaction GIFs anddownloader-waiting.gif.Mascot Components & Theme Helpers (loading-mascot.ts, fail-mascot.ts, player-loading-state.ts, use-resolved-theme.ts, use-player-loading-mascot.ts):
TymeMascotCard,LoadingMascot,FailMascot,VidstackLoadingMascot).Startup, Page & Player Integration (apps/web/index.html, VideoJsLoadingMascot, VidstackLoadingMascot):
index.htmlasset preloading and#app-loaderbackdrop to render theme-matched startup Tyme loading animations.PageSpinner,WatchLoadingIndicator,WatchPageSkeleton,WatchStage,EmbedLoading,ShortsShellLoader,ShortsPlayerStage,TwitchVideoView,TwitchWatchStage).VidstackLoadingMascotandVideoJsLoadingMascotto display Tyme prior to the first frame, falling back cleanly to unobtrusive ring spinners (DefaultBufferingIndicator/.vds-buffering-spinnerafter a 400ms delay) for mid-playback buffering and timeline seeks.FailMascotintoChannelLoadError,StreamError,PlayerError,EmbedError,ShortsError, andVideoJsRecoveryCover.Mascot Unit Tests (apps/web/tests/loading-mascot.test.ts, apps/web/tests/fail-mascot.test.ts, apps/web/tests/player-loading-state.test.ts, apps/web/tests/reaction-gifs.test.ts):