Repository navigation
fix: fit the Video.js controls on narrow players - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeType-Video/TypeType#426.
On a 375 px phone the Video.js bar held play, volume, the time, captions, settings, cinema, web fullscreen, AirPlay, picture-in-picture and fullscreen, and the time overlapped the buttons.
Below 28rem of player width (a container query, so it follows the player and not the screen):
Wider players keep the same bar. Checked at 375 px in Chromium (mobile emulation) and in Safari on an iPhone 12 mini simulator.