Skip to content

docs: CF-7 close-out receipt and live human-review candidate (#280) - #443

Merged
BunsDev merged 1 commit into
mainfrom
cf7-closeout
Oct 30, 2026
Merged

BunsDev merged 1 commit into
mainfrom
cf7-closeout

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Docs only. Adds docs/reviews/2026-10-29-cf7-closeout/checkpoint.md, which closes out CF-7's engineering work and hands Val the human review the issue lists as separate acceptance evidence.

  • The acceptance criteria. All seven are mapped to the PRs on main (Show the plan each CLI reports and save a turn's task record to Notes (CF-7, first part) #289 through feat: read Claude's task tools and Codex's proposed plan from live captures (#280) #394) and the unit and e2e tests that prove each one. Nothing is ticked on Val's behalf.

  • A real task per CLI, through the app in Chat mode. Both Claude Code 2.1.312 (Haiku) and codex-cli 0.164.0 (gpt-6.1-sol) did the same work:

    • ran a failing npm test;
    • edited greeting.txt after approval, then passed npm test;
    • showed "Verified: npm test passed after the last change";
    • saved a Task Note and reopened it as a read-only Task view, with the transcript unchanged.

    Neither CLI was offered a plan tool, and each turn said so. The reports, saved notes, task records and Task view screenshots are committed with personal paths redacted.

  • The seeded homes are kept under the worktree's apps/desktop/.probes/cf7-human/, so Val can open the saved Notes in the app. The receipt has the launch commands.

  • Three observations for Val (documented behavior, but worth a decision):

    • a file Claude wrote through a shell redirect is listed as "read";
    • Codex's perl -pi edit lists no file;
    • the note title cuts the request mid-word.
  • status.md and task-context.md are updated.

Checks. First pass on main at eca2bd9:

Suite Result
pnpm build passed
pnpm test, desktop 2,062 passed, 20 skipped, 0 failed
pnpm test, other packages all green
pnpm test:e2e, desktop 475 passed, 7 opt-in skips, 0 failed
pnpm test:e2e, site 7/7

The full log is in the receipt folder.

Refs #280. #280 stays open until Val records the review or a written deferral.

🤖 Generated with Claude Code

Hosted validation at 6b1bec2a77e6c8286c48b29e68cfa030b221877c. CI run 40985131404, attempt 1, failed the Canvas external-request/navigation/popup test when Escape did not restore the main view: 477 desktop tests passed, four skipped, one failed; site tests did not run. The first-failure log and trace are retained. Five unchanged local repetitions passed; that diagnostic checkout has identical Canvas source and tests but includes the separate ACP repair. The cause remains unproven. One controlled retry, attempt 2, passed 478 desktop tests with four skips and seven site tests. iPhone CI passed. No test or product change was made to obtain the retry result.

Review boundary. The committed screenshots show the read-only saved Task views and verification text; they also retain the documented file-reporting and clipped-title observations. These receipts do not substitute for Val's pending review in #280. The seeded human-review homes remain in the author-owned worktree.

Protected queue result. Queue run 40992737267, macOS job 123858729561, repeated the Canvas Escape failure at canvas.spec.ts:224: 477 desktop passes, four skips, one failure; site tests did not run. The first queue log and trace archive are retained, with artifact SHA-256 c757ad982439b9b2736ff8577aaad37df5af1a8f5365ab824212e3711f7ac32c. No further retry has been requested. A separate test-harness candidate waits for the native Canvas view to match the expanded preview before sending Escape. A controlled delayed-IPC diagnostic proves the existing renderer-hidden assertion alone is insufficient; it does not establish the unrecorded event ordering of this hosted failure. Five candidate repetitions passed, and full validation is in progress. This PR remains unmerged pending that repair and fresh protected validation.

Maps every CF-7 acceptance criterion to the PRs and tests on main at
eca2bd9. Records one real task per CLI through the app in Chat mode
(Claude Code 2.1.312 Haiku; codex-cli 0.164.0 gpt-6.1-sol): failing
npm test, approved edit, passing check, "Verified", Save to Notes and a
read-only Task view reopen. Keeps the seeded homes for Val's review and
lists three observations for a decision. Full first pass: unit all
green, desktop e2e 475 passed / 7 opt-in skips, site 7/7.

Docs only; no source change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 30, 2026 1:19am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 2eda138 cf7-closeout 6b1bec2 +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 30, 2026
@BunsDev
BunsDev added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 3d52f8b Oct 30, 2026
13 of 14 checks passed
@BunsDev
BunsDev deleted the cf7-closeout branch October 30, 2026 04:30
BunsDev added a commit that referenced this pull request Nov 1, 2026
* Correct merged PR dates to October 31 UTC (#470)

* docs: point the CF-7 review kit at its restored location (#280) (#473)

The cf7-closeout worktree was pruned after #443 merged, so the receipt's
launch commands pointed at nothing. The saved homes are restored into the
cf7-review-kit worktree from the task-evidence copy, and both saved Task
Notes reopen read-only on a build of 0a8c513. Records the two things a
reviewer will see: the notes predate #450, and the homes name the old
repository path. No human row changes.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
BunsDev added a commit that referenced this pull request Nov 4, 2026
* Correct merged PR dates to October 31 UTC (#470)

* docs: point the CF-7 review kit at its restored location (#280) (#473)

The cf7-closeout worktree was pruned after #443 merged, so the receipt's
launch commands pointed at nothing. The saved homes are restored into the
cf7-review-kit worktree from the task-evidence copy, and both saved Task
Notes reopen read-only on a build of 0a8c513. Records the two things a
reviewer will see: the notes predate #450, and the homes name the old
repository path. No human row changes.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 6b1bec2a Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant