[springmeyer]

PR with the work from #830

Squashed version of #979

[springmeyer]

Blocked on nodejs/node-addon-api#57

Note the commented RegExp, Integer, and Date support at https://github.com/mapbox/node-sqlite3/blob/48f5e44ae44b21bb6dd409e288249be57f33c3ba/src/statement.cc#L167-L189.

This results in:

  data types
Error: async hook stack has become corrupted (actual: 548, expected: 549)
 1: 0x86de5e node::InternalCallbackScope::~InternalCallbackScope() [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 2: 0x89bd6e node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 3: 0x869ba6 node::AsyncWrap::MakeCallback(v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 4: 0x942c01  [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 5: 0x9c66a5  [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 6: 0x9b880c uv_run [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 7: 0x8a4a2d node::Start(v8::Isolate*, node::IsolateData*, int, char const* const*, int, char const* const*) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 8: 0x8a3cd6 node::Start(int, char**) [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
 9: 0x7f21fbaa87ed __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6]
10: 0x861845  [/home/travis/build/mapbox/node-sqlite3/__nvm/versions/node/v10.5.0/bin/node]
npm ERR! Test failed.  See above for more details.

[anisha-rohra]

@springmeyer I have managed to implement the IsDate and IsRegExp functions and am working on a PR. However, I found a bug in the current existing port that I'm in the midst of fixing so I'll have an update with both fixes in soon. The PR I'm working on is at mhdawson#3.

[springmeyer]

Thank you for the update @anisha-rohra - I'll wait for word here that you've solved the problem.

[bpasero]

Excited to see this 👍

[springmeyer]

@anisha-rohra what is the status of mhdawson#3? Is it ready to pull in here? /cc @mhdawson

[mhdawson]

Still working on it with Anisha. In the latest review we realized there is still direct use of libuv that we want to remove as well. Not sure if that is related to the hand Anisha was investigating but it might be so @anisha-rohra is going to look at that first.

[springmeyer]

@mhdawson any update on whether mhdawson#3 is ready to test and/or merge?

[springmeyer]

@mhdawson when you have an updated branch, please create a new PR again https://github.com/mapbox/node-sqlite3/pulls

[mhdawson]

@springmeyer will do, Anisha is working on removing the direct libuv usage which was the last part. Just back from vacation but hope to catch up with her on where she is with that this week.