Repository navigation
feat(check-payments): reprocess a check marked for return - #94
Merged
Merged
Conversation
Collaborator
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
samuelvasco
marked this pull request as ready for review
November 17, 2026 13:28
Adds CheckPaymentResource.reprocess, which posts to
check-payments/{id}/reprocess. Unit support confirmed (Zendesk case
169500) that a check presented with insufficient funds can be paid by
funding the account and calling this endpoint while the check is still
MarkedForReturn. The api needs it to extend Balance Protection to
checkbook checks (ENG-6568).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samuelvasco
force-pushed
the
eng-6568-check-payment-reprocess
branch
from
November 17, 2026 16:11
ed62e92 to
bb1e737
Compare
avesk
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Human description
Adds
CheckPaymentResource.reprocess, which posts tocheck-payments/{id}/reprocess. Unit support confirmed (Zendesk case 169500) that a checkbook check presented with insufficient funds can be paid by funding the account and calling this endpoint while the check is stillMarkedForReturn. The api needs it to extend Balance Protection to checkbook checks.Related to https://linear.app/trusspayments/issue/ENG-6568/spike-balance-protection-for-checks
AI description
Agent-authored with Claude Code.
Summary
One new method on
CheckPaymentResource, shaped likecancel(POST, no body) and likeReceivedPaymentResource.reprocess. It decodes the returnedcheckPaymentor returnsUnitError.Correctness vs root cause
Adds a missing endpoint. No existing behaviour changes.
Scope / pattern fit
Additive. Follows the neighbouring resource methods and the mocked-
requeststest style ofe2e_tests/test_account_lookup.py.Security
None. Same org token and scope (
check-payments-write) asapproveandreturn_check.Performance
None.
Concurrency
None.
Observability
Unchanged.
Decisions
received-payments/{id}/reprocesshas none either.check_e2e run --scenario funded_nsf_check_reprocess_pays) that must pass before the api change merges.Risks
Low. If Unit expects a body, the call returns a
UnitErrorand the api lets the check be returned as it is today.Verification
python -m unittest e2e_tests.test_check_payment_reprocess -v: 2 tests OK (URL and empty body, DTO decode,UnitErrorpath).Rollout
The api pins this branch's commit (
ed62e92). If this PR is squashed, the api pin must move to the merge commit onmasterbefore the api PR merges.🤖 Generated with Claude Code