Skip to content

feat(accounts): replace verification with filtered account lookup - #92

Merged
samuelvasco merged 1 commit into
masterfrom
codex/unit-account-lookup
Nov 4, 2026
Merged

samuelvasco merged 1 commit into
masterfrom
codex/unit-account-lookup

Conversation

@samuelvasco

@samuelvasco samuelvasco commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Human description

AI description

Agent-authored with Codex.

Replace the deprecated account-verification API with routing-number and account-number filters on account listing. Forward the caller's timeout through the existing GET transport and remove the old request/response types and resource method. Migrate the existing mocked verification tests to account lookup tests.

New words: none.

Validation: four mocked SDK tests pass (python -m unittest e2e_tests.test_account_lookup -v), covering filters, GET transport/timeout, customer relationship decoding, empty responses, and Unit errors. The consuming API change passed 108 focused tests and the complete make ai-verify gate with 112 selected tests. No live Unit token or forwarded environment was used; Sam-run sandbox smoke validation remains pending.

The API companion PR pins this exact SDK commit. Human review and SDK merge must precede API rollout; update the API pin if the SDK merge changes the commit SHA.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Account listing now accepts routing and account number filters and an optional timeout. The account verification method, its models, and its tests have been removed.

Changes: Account lookup

Layer / File(s) Summary
Account lookup filters and request
unit/models/account.py, unit/api/account_resource.py, e2e_tests/test_account_lookup.py, e2e_tests/test_account_verify.py
ListAccountParams serializes routing and account number filters. AccountResource.list forwards an optional timeout. Tests cover serialization, successful and empty results, request arguments, and a 400 response. The account verification method, models, and tests are removed.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: avesk, axshani

Merge Risk: Minimal · up to ea287

No concrete merge-blocking defect is established in the account lookup changes. Live sandbox validation remains pending, and the reported CI failures still need diagnosis before relying on those results.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes replacing account verification with filtered account lookup, which is the main change.
Description check Passed The description directly explains the account lookup filters, timeout forwarding, removed verification types and method, migrated tests, and validation results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c7e3e250-0aad-405d-923f-987c2df5287f
Commits

Reviewing files that changed from the base of the PR and between 8d83a65 and ea2873e.

Files selected for processing: 4
  • e2e_tests/test_account_lookup.py
  • e2e_tests/test_account_verify.py
  • unit/api/account_resource.py
  • unit/models/account.py
Files with no reviewable changes: 1
  • e2e_tests/test_account_verify.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copy link
Copy Markdown
Collaborator Author

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@samuelvasco
samuelvasco marked this pull request as ready for review November 4, 2026 17:27
@samuelvasco
samuelvasco merged commit 868deab into master Nov 4, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants