Skip to content

chore(deps): bump requests dev pin to 2.32.5 - #89

Closed
claude[bot] wants to merge 2 commits into
masterfrom
claude/dependabot-requests-dev-bump
Closed

claude[bot] wants to merge 2 commits into
masterfrom
claude/dependabot-requests-dev-bump

Conversation

@claude

@claude claude Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Requested by Shawni · Slack thread

Before: requirements-dev.txt pins requests==2.26.0 (September 2021). That pin carries four open Dependabot advisories: CVE-2023-32681 (GHSA-j8r2-6x86-q33q, Proxy-Authorization leak on HTTPS-to-HTTP redirect, fixed 2.31.0), CVE-2024-35195 (GHSA-9wx4-h78v-vm56, verify=False sticks for the Session, fixed 2.32.0), CVE-2024-47081 (GHSA-9hjg-9r4m-mvj7, .netrc credential leak to a third-party host, fixed 2.32.4) and CVE-2026-25645 (GHSA-gc5v-m9x4-r6x2, fixed 2.33.0). It is also the only versioned dependency in this repo's GitHub dependency graph, so it is the sole source of Dependabot alerts here, and those alerts are what surface in Vanta's "packages checked for vulnerabilities" tests.

After: the dev pin is requests==2.32.5, the newest release that still installs on the Python 3.9 that CI.yml uses. It clears CVE-2023-32681, CVE-2024-35195 and CVE-2024-47081. It does not clear CVE-2026-25645: every fix release for that one (2.33.0 and later) declares Requires-Python: >=3.10, so closing it needs CI.yml moved to Python 3.10+ first (the first push of this PR pinned 2.33.0 and failed CI at pip install for exactly this reason). That workflow change is deliberately left out of this PR. Runtime install_requires in setup.py is unchanged (requests, unbounded), so consumers need no bump: Truss-pmts/api pins this repo by git SHA and pip never reads requirements-dev.txt when installing from a git URL.

How: one-line pin change in requirements-dev.txt, verified with a fresh pip install -r requirements-dev.txt (resolves requests 2.32.5 / urllib3 2.8.0) and pip-audit -r requirements-dev.txt --no-deps reporting only the remaining PYSEC-2026-2275 / CVE-2026-25645 finding; the pytest suite was not run locally because every test in e2e_tests/ calls Unit's live API with a TOKEN credential.

🤖 Generated with Claude Code

https://claude.ai/code/session_016RsygiGnNsdqxz2PMoPtbQ

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 56ce44e1-40ac-4022-9771-535817a415e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@claude
claude Bot requested a review from carjona-truss September 18, 2026 23:33
…needs 3.10

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016RsygiGnNsdqxz2PMoPtbQ
@claude claude Bot changed the title chore(deps): bump requests dev pin to 2.33.0 chore(deps): bump requests dev pin to 2.32.5 Sep 18, 2026
@claude

claude Bot commented Sep 18, 2026

Copy link
Copy Markdown
Author

CI status on this PR (build check)

Failing check: build → step Test with pytest, on head c7d3e41 (run 35406416892). Install dependencies passed on this head.

Error: the step exits with Process completed with exit code 1 at log line 1189 (from the check-run annotation). I could not read the raw log text from this environment because results-receiver.actions.githubusercontent.com / the Azure blob log host are blocked by proxy policy. To see the pytest output: gh api repos/Truss-pmts/unit-python-sdk/actions/jobs/105796991099/logs | tail -80.

Why this is not caused by this change: the PR only changes the requests pin in requirements-dev.txt, which is exercised by the Install dependencies step; that step now succeeds. The Test with pytest step fails in exactly the same way on the previous PRs, before this change existed:

CI.yml triggers only on pull_request_target, so build has never run on master itself; the only workflow running on master is the scheduled CodeQL scan, which is green (run 35005985970, head e2e1424). Every test in e2e_tests/ calls Unit's live sandbox API with the UNIT_TOKEN secret, so the failure is in the e2e suite / sandbox state, not in this dependency bump.

For the record, the first push of this PR (c0f21a0, run 35406179472) did fail because of this PR: it pinned requests==2.33.0, which declares Requires-Python: >=3.10 while CI uses Python 3.9, so pip install failed. c7d3e41 lowers the pin to 2.32.5 (last 3.9-compatible release) and that step is now green. Clearing the remaining CVE-2026-25645 advisory needs CI on Python 3.10+, which is outside this PR.

No fix for the Test with pytest failure exists within this PR's scope; not pushing further changes.


Generated by Claude Code

@gamal-truss

Copy link
Copy Markdown

Superseded by the requests 2.34.2 + Python 3.11 bump (closes the remaining CVE-2026-25645 that 2.32.5 could not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants