Skip to content

fixing slow tests - #1877

Merged
jlarson4 merged 1 commit into
mainfrom
feat/slow-tests
Oct 9, 2026
Merged

jlarson4 merged 1 commit into
mainfrom
feat/slow-tests

Conversation

@jlarson4

@jlarson4 jlarson4 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Fixing slow nightly tests

@jlarson4
jlarson4 merged commit a9a43e4 into main Oct 9, 2026
jlarson4 added a commit that referenced this pull request Oct 21, 2026
* fixing slow tests (#1877)

* Fixing failing Slow test
jlarson4 added a commit that referenced this pull request Nov 6, 2026
…_results (#1976)

* fixing slow tests (#1877)

* fix(ActivationCache): reject a negative remainder layer in stack_head_results

stack_neuron_results got a guard in #1875: with incl_remainder=True, a
layer below 0 raises, because range(layer) is empty and the remainder
reads resid_post[layer - 1], which __getitem__ wraps to a late layer.
stack_head_results has the same code path and never got the guard.

On a 4-layer model stack_head_results(-2, incl_remainder=True) returns
one component labelled "remainder" that is resid_post[1], with no error.
On a 2-layer model the same call fails with a KeyError on
blocks.-1.hook_resid_post instead of the sibling's ValueError.

Raise the same ValueError as the neuron stack. layer=0 stays valid and
still returns the whole final residual stream, and incl_remainder=False
is unchanged.

---------

Co-authored-by: Jonah Larson <jonahalarson@comcast.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant