Repository navigation
tools/run_tests.sh: add build-staleness gate - #47
Merged
Merged
Conversation
Running tests against a stale native/Java build after a source edit produces output indistinguishable from a real regression, and has repeatedly cost real debugging time chasing bugs that were actually just an old binary. Fail loudly with a grep-able STALE_BUILD_ERROR: line instead. JCEF_SKIP_STALE_CHECK=1 overrides when needed. Backport of coverage/phase1-value-objects-phase2-handlers' bd7bff1. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HBFmQs6JDypYP5qdC99yDq
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
============================================
- Coverage 38.01% 37.99% -0.03%
+ Complexity 735 732 -3
============================================
Files 243 243
Lines 14863 14863
Branches 2449 2449
============================================
- Hits 5650 5647 -3
- Misses 8011 8012 +1
- Partials 1202 1204 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_stale_buildgate that fails loudly with a grep-ableSTALE_BUILD_ERROR:line whenlibjcef.soor the compiled Java classes are older than their sources.JCEF_SKIP_STALE_CHECK=1overrides when needed.coverage/phase1-value-objects-phase2-handlers'bd7bff1, infra-only, no test-visible behavior change beyond the new guard. Independent of PR tools/run_tests.sh: fix --select-class scope leak; make leak-sweep opt-in only #44 (different section of the same file: that PR fixes--select-classscope-leak + leak-sweep opt-in, this adds the staleness check inserted earlier in the script).Test plan
bash -n tools/run_tests.sh(syntax check)check_stale_build()against synthetic old/new mtimes -- correctly fails when source is newer than artifact, passes when artifact is newer🤖 Generated with Claude Code
https://claude.ai/code/session_01HBFmQs6JDypYP5qdC99yDq