Repository navigation
Conversation
Collaborator
Author
|
Verdict: PASS (tip 387e41b)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #907
runstore.createnow turns anOSErrorfrom creating the store root or the run directory into aRunStoreErrornaming the path and the OS reason, and reports a store path that is an existing file asnot a directory. The CLI therefore exits 2 with oneerror: cannot create run store <path>: <reason>line, and--jsonreturns{"ok": false, "error": ...}.The wrap stays inside
create()(no blanket CLI-edgeOSErrorhandling), sotests/test_audit_store_durability.pystill seesPermissionErrorfor audit-path failures.Verified on the box:
--store /proc/adstore,/etc/passwd,/root/adstoreall exit 2 with no traceback, text and--json.Tests:
tests/test_store_create_error.py(fails on main): file path, patchedos.makedirsEROFS, run-dir ENOSPC, anddemoexit 2 with/without--json. Docs:docs/plugins.mdrun-store section. Changelog:changelog.d/907-store-create-error.md.