Skip to content

Harden nightly advisory browser and perf lanes - #249

Merged
hsliuustc0106 merged 2 commits into
mainfrom
cursor/harden-nightly-advisory-lanes-23fa
Nov 11, 2026
Merged

hsliuustc0106 merged 2 commits into
mainfrom
cursor/harden-nightly-advisory-lanes-23fa

Conversation

@hsliuustc0106

@hsliuustc0106 hsliuustc0106 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Rebased onto current main 4d15b4e4 (4d15b4e445756d8631f34b03b71447a1e90ce0dc), which includes Zhipu GLM chat from #245 and the later fixes through that tip.

Branch tip: 2be9ef65 (2be9ef656836fb9f61fca2ca179ef799affd8c31).

Nightly advisory lanes (browser-production, browser-extended, perf-outputs) stay hardened. Release-checks required gates, performance thresholds, and the package version are unchanged. The rebase had no conflicts.

Release checks on the previous tip 31399ad6 failed in tests/browser/voice_library.mjs (reopenAudio waited 15s for “Saved on this device”): https://github.com/ThinkFlowLab/OpenDirector/actions/runs/42761453608. That wait is already 45s on this main (090c9817). This branch does not edit that script. Re-running it on the rebased tree passed.

  • Dismiss the model-setup welcome before canvas clicks, including the timeline text coverage and render scripts.
  • Point extendedFixture scripts at the assistant fixture web (:5180) and API (:8020).
  • Keep the activity harness off production preview.
  • Give default entry its own project on a shared server, and follow immediate project creation.
  • Hold history flush, reference-chip undo, and the JiuwenSwarm recheck on the requests those journeys actually make.

Ctrl+Z in the prompt restores a reference-only chip removal. The connected-reference picker stays open after focus.

Linked issue

  • Refs #200 — the nightly plan stays open. This pull request does not use Fixes #200.

Labels

  • Labels applied

Test plan

  • Local on this tip: node scripts/check-browser-manifest.mjs (70 entries). tests/browser/locale.mjs and tests/browser/voice_library.mjs passed against fresh fixture servers. The voice-library run is the gate step that failed on 31399ad6.
  • Earlier, before this rebase: the scripts that failed in nightly run 42527176813 passed locally, and the ChatReferenceEditor screenshots below were captured from passing canvas_reference_sources.mjs and control_theme.mjs runs.
  • Left to CI: Release checks on 2be9ef65. The full GitHub nightly was not reproduced. timeline_text_coverage.mjs and timeline_text_render.mjs were not executed. This machine is Node 22.23.4; Release checks use 24.22.1.

Evidence that it works

  • Media attached, or N/A because:

Connected-reference picker still open after the button focuses the prompt (no @ in the text):

Connected-reference picker stays open

Reference chips before removal, after removing 原版_时长裁剪.mp4, and after Ctrl+Z in the prompt. The browser script asserted the chip count returned from 1 to 3 and the edge count returned to 2 before the last shot.

Reference chips before removal

Video reference chips removed

Video reference chips restored by Ctrl+Z

Provider verification

  • Real-provider calls are described honestly, or none were made

No real provider calls. Browser runs used the isolated creation-server and voice-library fixtures.

Bilingual UI

  • Both locales are updated, or no user-facing copy changed

No user-facing copy changed.

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

@hsliuustc0106 hsliuustc0106 added type:ci Build, test and release automation area:ci Continuous integration and checks labels Nov 10, 2026
@cursor
cursor Bot force-pushed the cursor/harden-nightly-advisory-lanes-23fa branch from 9d22942 to 31399ad Compare November 10, 2026 05:19
cursoragent and others added 2 commits November 10, 2026 20:00
- Dismiss the model-setup welcome before canvas clicks so a fresh
  server does not cover the extended and perf lanes.
- Point extendedFixture scripts at the assistant fixture web and API.
- Keep the activity harness off production preview, which cannot
  serve its Vite test module.
- Open default entry on a project that script owns, and follow the
  immediate project-create flow.
- Hold history flush, reference undo, and the JiuwenSwarm recheck
  on the requests those journeys actually make.

- `node scripts/check-browser-manifest.mjs`
- Isolated browser runs of the scripts that failed in nightly run
  42527176813, plus locale, tool drafts, and the drag profile.
- The full GitHub nightly was not reproduced.

Related to #200

Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
## summary

- Dismiss the model-setup welcome in the timeline text coverage and
  render scripts added on main. They are extended-lane pages, and the
  manifest check rejects a page that omits the dismissal.

## validation

- `node scripts/check-browser-manifest.mjs`

Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
@cursor
cursor Bot force-pushed the cursor/harden-nightly-advisory-lanes-23fa branch from 31399ad to 2be9ef6 Compare November 10, 2026 20:01
@hsliuustc0106
hsliuustc0106 merged commit a9d02b6 into main Nov 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Continuous integration and checks type:ci Build, test and release automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants