Skip to content

[test] Cover colored CLI help and hidden generation references - #163

Merged
hsliuustc0106 merged 5 commits into
mainfrom
codex/issue-160-browser-locale
Nov 6, 2026
Merged

hsliuustc0106 merged 5 commits into
mainfrom
codex/issue-160-browser-locale

Conversation

@hsliuustc0106

@hsliuustc0106 hsliuustc0106 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add coverage for CLI help in both colored and plain terminal output, and verify that hiding a referenced source during generation preserves the saved configuration and creates an unadopted candidate. The creation browser workflow also checks that the candidate is not automatically adopted.

The locale and underlying CI fixes were merged into main in #164 and #165.

Refs #160

Validation

  • Python suite: 920 passed, 6 skipped (optional external CLI and opt-in integration tests).
  • Frontend tests: 586 passed; bilingual catalog check and production build passed.
  • Full isolated browser workflow passed, including real MP4 render and export.
  • Generated contracts and independent wheel installation checks passed.

- Set the locale and dismiss first-run setup in browser workflows.
- Check English and Chinese canvas status text in an isolated browser.

Refs: #160
## summary

- Verify cached commit content on filesystems where signatures alone
  cannot reliably detect rewrites.
- Align command descriptions and test fixtures with current behavior.

## validation

- Nine reported tests passed; generated contracts verified.
- Full suite: 918 passed, 3 skipped, and one help-text assertion failed;
  that assertion and the gateway test passed after the final wording fix.
@hsliuustc0106 hsliuustc0106 changed the title [ci] Make browser workflow locale deterministic [ci] Stabilize browser locale and fix reported test failures Nov 6, 2026
## summary

- Strip terminal styles before checking CLI help options and exercise
  both colored and plain output.

## validation

- CLI tests passed with forced color (14 passed).
hsliuustc0106 added a commit that referenced this pull request Nov 6, 2026
## summary

- Integrate Python and generation fixes from PR #165.
- Apply locale fixtures from PR #163 and align browser workflows with
  current activity, model settings, and project creation behavior.

Refs: #160, #161, #162
## summary

- Keep projected generation inputs separate from the persisted spec when
  registering a result after a referenced canvas item is hidden.
- Verify the result remains a candidate until explicitly selected.

## validation

- Generation service tests passed (6 tests).
- The isolated creation browser workflow passed.
@hsliuustc0106
hsliuustc0106 marked this pull request as ready for review November 6, 2026 16:12
@cursor

cursor Bot commented Nov 6, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

…er-locale

# Conflicts:
#	packages/core/src/opendirector/domain/creation/commands.py
#	packages/core/src/opendirector/infrastructure/creation_projects.py
#	scripts/verify_creation_browser.mjs
#	src/contracts/creation.schema.json
#	tests/browser/assistant_activity.mjs
#	tests/browser/canvas_crop.mjs
#	tests/browser/canvas_generation_reference.mjs
#	tests/browser/canvas_layers.mjs
#	tests/browser/context_menu_dismissal.mjs
#	tests/browser/created_node_focus.mjs
#	tests/browser/cross_canvas_paste.mjs
#	tests/browser/editor_save.mjs
#	tests/browser/local_output_delivery.mjs
#	tests/browser/minimax_h3.mjs
#	tests/browser/mp4_export.mjs
#	tests/browser/project_list_overflow.mjs
#	tests/browser/provider_settings.mjs
#	tests/browser/reference_reconnect.mjs
#	tests/browser/structured_editors.mjs
#	tests/browser/timeline_workflow.mjs
#	tests/test_cli.py
#	tests/test_creation_generation_service.py
#	tests/test_self_hosted.py
@hsliuustc0106 hsliuustc0106 changed the title [ci] Stabilize browser locale and fix reported test failures [test] Cover colored CLI help and hidden generation references Nov 6, 2026
@hsliuustc0106
hsliuustc0106 merged commit 400e1dd into main Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant