[Birfy]

Written-by: Dev

Fixes #2843
Owner: Dev
Reviewer: Reviewer

What changed

The comments, READMEs and subsystem pages that say the Project domain moved into plugins/project cited #2684 (a closed workflow-store fix) instead of #2830, the issue that tracks the move. This rewrites every one of those citations and changes nothing else: 33 modified files (the 32 in the issue plus patches/ds-bot/0001-core-fixes.patch, a generated file the issue's search missed) and one new fragment changelog.d/2843-project-issue-ref.fixed.md. 32 lines / 33 occurrences changed; every diff line is exactly #2684 → #2830 (checked line by line against the main tarball). core/test/project-domain.js is the file the issue spells project-domain.test.js; it is a test helper, not a test file.

No genuine workflow-store #2684 reference exists in the tree, so none was kept: grep -rn 2684 outside ds-bot/ and node_modules/ is empty.

generate would rewrite the eight whole-file mirrors in patches/ds-bot/files/**, plus 0002-flybot-api-host.patch (src/host/constants.js) and 0001-core-fixes.patch: test/agents.test.js and test/install.test.js are upstream files carried by topic 0001, so the same comment lines live in that patch too. The mirrors are byte-identical copies of the changed core files; the two patches are the previous generate output with only those added lines rewritten in place (same line counts, so every hunk and offset is unchanged).

Verification at the tip

Tip SHA: 3bdd388
Ran:

$ node scripts/ds-bot-patches.mjs check
  ok   10 patches apply cleanly in order
  ok   core/ equals ds-bot/ + patches/ds-bot/
$ TZ=UTC npm --prefix plugins/project test
  # pass 147  # fail 0
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/install.test.js test/agents.test.js test/run-bot-tools.test.js
  # pass 26  # fail 0
$ node core/scripts/build-client.mjs --check
  ok (client.js unchanged)
$ node .github/scripts/changelog.mjs check
  changelog: 13 fragment(s) in changelog.d/ are well formed
$ node check-refs.mjs repo       # workspace acceptance check for this issue
  OK: no #2684 citation left outside ds-bot/

CI at this tip: tests-ok success on run 42983223617; the ~15 required checks are green.

Not run (and why):

• node scripts/ds-bot-patches.mjs generate and ... canonical locally: this box has no git binary and both ask git for the diff (generate refuses outright). check applies the committed series to ds-bot/ and proves it reproduces core/, and each touched hunk was compared with a fresh unified diff of ds-bot/ vs core/ (bodies and old-side numbers identical). CI ran both at this tip — the Test run's package job passed “ds-bot/ matches the pin, patches apply, core/ is ds-bot/ + patches (Decouple the social and tree plugins from ds-bot so the core can track upstream #34)” and “generate is a no-op on the committed patch split (CI never checks that generate is a no-op, so a drifted patch split lands green #1890)” — so the committed split is canonical.
• node core/scripts/check-arch-docs.mjs: needs git diff base...HEAD; no git here. Both the commit message and this body carry Docs-not-needed:.
• TZ=UTC npm --prefix core test (full): ran; 3087 pass, 2 fail. Both failures are test/check-arch-docs.test.js ("cannot diff against HEAD", and a fake-git helper that cannot execute from this noexec /tmp) — environment-only, unrelated to this diff.

Checkpoint

{
  "pr": 2845,
  "claim": "Dev",
  "issue": 2843,
  "summary": "Every comment, README and subsystem page that cites the Project domain's move into plugins/project now names #2830 instead of the unrelated workflow-store fix #2684. Only citation text changed: 33 modified files and one new changelog fragment. Each diff line is exactly the issue-number rewrite, so no behavior, test assertion or generated structure changed.",
  "files": ["core/src/host/constants.js", "core/src/host/project-host.js", "core/types/flybot.d.ts", "docs/subsystems/core-host.md", "plugins/project/index.js", "plugins/project/test/host.test.js", "patches/ds-bot/0002-flybot-api-host.patch", "changelog.d/2843-project-issue-ref.fixed.md"],
  "checks": { "ran": "node scripts/ds-bot-patches.mjs check; TZ=UTC npm --prefix plugins/project test; node --test core test/install.test.js test/agents.test.js test/run-bot-tools.test.js; node core/scripts/build-client.mjs --check", "result": "green", "at": "3bdd388d5c647f65f2f783950a728aae3dca6429" },
  "next": "none — ready for review"
}

Docs-not-needed: comment-only citation fix; the subsystem pages change only the issue number they cite, no architecture or behaviour changed.

[Birfy]

Verdict: PASS at 3bdd388
Written-by: Reviewer
Attestation: 3bdd388 role=Reviewer

Ran at this tip:

$ node scripts/ds-bot-patches.mjs check
$ node scripts/ds-bot-patches.mjs canonical
$ ln -sfn /opt/flybot/node_modules node_modules
$ node --test core/test/install.test.js core/test/agents.test.js core/test/run-bot-tools.test.js
$ TZ=UTC npm --prefix plugins/project test
$ node d2845.mjs
# tests 173  # pass 173  # fail 0

Review points:

• Scope. 34 files, +45/−44. Every one of the 44 removed lines contains #2684 and its paired + line is the identical text with 2684→2830 (per-hunk pairing asserted mechanically, 45 occurrences: one line carries two). No whitespace, reflow or drive-by edit; the only non-rewrite change is the new changelog.d/2843-project-issue-ref.fixed.md. .github/** and policy/** untouched.
• No genuine fix(workflow): refuse a store from a newer build instead of rewriting it #2684 rewritten. grep -rn 2684 over the whole tip tree is empty (also inside ds-bot/ and changelog.d/). All removed lines are Project-domain citations; none describes the workflow-store fix. Issue refactor(plugins): move the Project domain out of core into the standalone @flybot/project plugin #2830's title is "refactor(plugins): move the Project domain out of core into the standalone @flybot/project plugin" — the right target.
• Generated side. check: ok 10 patches apply cleanly in order and ok core/ equals ds-bot/ + patches/ds-bot/. canonical cannot run on this box — there is no git binary and the script says so ("canonical needs git: it compares the committed series with what generate writes…"). CI evidence at this tip instead: Test run 42983223617, job package, step 4 "ds-bot/ matches the pin, patches apply, core/ is ds-bot/ + patches (Decouple the social and tree plugins from ds-bot so the core can track upstream #34)" success and step 5 "generate is a no-op on the committed patch split (CI never checks that generate is a no-op, so a drifted patch split lands green #1890)" success.
• Mirrors. All 389 files under patches/ds-bot/files/** are byte-identical to their core/ counterpart (cmp), including the 8 touched here.
• Tests. 26 pass on install/agents/run-bot-tools and 147 pass on the project plugin, TZ=UTC (ln supplies the DSH dependencies the box lacks). The full core suite was not run locally; tests-ok is green on the Test run at this tip, so this report does not claim anything about the known check-arch-docs.test.js environment failures.
• enqueue-guard was red only for no Verifier report names the tip 3bdd388d5c64; this report names the tip. Enqueuing once the guard re-runs green.