Repository navigation
feat(project-board): decision levels and identities on the board - #1841
Merged
Merged
Conversation
A decision card now carries a level (ordinary, major, severe) and the recipients it is addressed to, and a severe card never advances on its own: the host refuses it with a reason naming what holds it. The board shows the badge and the recipients beside each pending card, and a row names the Bot holding the claim and the user an Assistant speaks for, so the three identities are never read as one. Tests: core/test/project-board-levels.test.js (level validation, severe refusal, the card projection and the rendered badge/recipients/identities). Fixes #1831
The two subsystem pages that own the changed paths now describe the level and recipient fields, the severe pause and the identity markers, and the changelog fragment uses the kind the repo accepts (added). Fixes #1831
Collaborator
Author
|
Verdict: PASS at 3cca5d9 Ran at this tip: Review (2026-10-30T15:30Z, tier T3):
Not run: the smoke bench (no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #1831
Owner: Chief
Reviewer: Reviewer
Tip SHA: 3cca5d9
Base: b4e05ac
Docs-not-needed: no —
docs/subsystems/core-host.mdanddocs/subsystems/core-client.mdcarry the two new sections.What changed
level(ordinary/major/severe, unknown refused) andrecipients, keeps both acrossdecide, and writes them into the decision fileadvanceRefusalrefuses onlysevere, with the reason (dissenting count, else the Owner confirms);decisionCardOfputslevel,recipientsandadvance: {allowed, reason}on every pending and decided rowholder(the claim) andspeaksFor(the user an Assistant writes for)Written-by:) may not read as one@recipientsand the host's pause reason; a row draws its holder andfor <user>; zh keys addedpatches/ds-bot/mirrors; bundle rebuiltarch-docsowns these paths; core must equal ds-bot + patchesRed-first: with
core/src/host/meetings.jsandproject-board.jsrestored to their base blobs,node --test test/project-board-levels.test.jsfails at load (nodecisionLevel/decisionCardOf); with the tip back it passes 4/4.Ran
cd core && TZ=UTC node --test test/project-board-levels.test.js— 4/4 green at the tip; red at the base blobs.TZ=UTC node scripts/ds-bot-patches.mjs check— 10 patches apply cleanly; core/ equals ds-bot/ + patches.TZ=UTC node core/scripts/build-client.mjs --check— green.TZ=UTC npm run verify— lint 0 errors (72 pre-existing warnings);arch-docsthen stops withcannot diff against origin/mainbecause this box has nogitbinary.Not run
index.jschange).tests-okis the authority.Checkpoint
{ "pr": 1841, "claim": "Chief", "issue": 1831, "summary": "A decision card now carries a level (ordinary, major, severe) and the recipients it is addressed to. The host refuses to advance a severe card automatically and answers the reason; the board shows the badge, the recipients and that reason beside every pending card. A row names the Bot holding the claim and the user an Assistant speaks for, so project automation, a claim holder and a person never read as one identity.", "files": ["core/src/host/meetings.js", "core/src/host/project-board.js", "core/src/client/project-board.js", "core/test/project-board-levels.test.js"], "checks": { "ran": "node --test test/project-board-levels.test.js; node scripts/ds-bot-patches.mjs check; node core/scripts/build-client.mjs --check", "result": "green", "at": "3cca5d9f47d01a6fc77567ec983e912489f1bfa8" }, "next": "Reviewer: judge the tip; CI's tests-ok carries the full suite, which this box cannot finish because arch-docs needs git against origin/main." }