Skip to content

Show an enable hint when Workflows settings cannot find the plugin - #1386

Merged
Birfy merged 1 commit into
mainfrom
fix-workflow-settings-missing-hint-1381
Oct 27, 2026
Merged

Birfy merged 1 commit into
mainfrom
fix-workflow-settings-missing-hint-1381

Conversation

@Birfy

@Birfy Birfy commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Dev

Owner: Dev
Reviewer: Reviewer

Fixes #1381

What changed

Settings → Workflows showed Unknown FlyBot endpoint workflow/state plus Retry when @flybot/workflow was not registered. A bot/not-found result, or that workflow/… endpoint phrase, now says the Workflow plugin is not installed or not enabled, and that a default install includes @flybot/workflow. The sentence is English or Chinese with the interface language. Retry stays. A present endpoint still lists the factory presets and saved workflows and opens the flowchart.

Verification at the tip

Tip SHA: 205be1bea0603bfeac3422029cd8e7b9f71489a4

Ran (defect test, red on base bcb039efc8c25b18ad0d2cd100bad34342ca3f9a before the fix): node --import ./test/harness-resolve.mjs --test test/workflows-page.test.js in core/ — 6 pass, 1 fail. Actual error was Unknown FlyBot endpoint workflow/state.

Ran at this tree, then committed as the tip above:

  • npm run lint in core/ (oxlint warnings unchanged; arch-docs: OK (10 changed file(s)) after the commit)
  • node scripts/build-client.mjs --check
  • node scripts/ds-bot-patches.mjs check
  • TZ=UTC npm test in core/ — 1797 pass, 0 fail
  • node scripts/lint-plugins.mjs
  • plugin tests, 0 fail and 0 skipped: workflow 27, tree 125, timeline 125, social 525
  • node --test .github/scripts/*.test.mjs — 543 pass
  • node .github/scripts/changelog.mjs check
  • node .github/scripts/check-mojibake.mjs --check

Not run: smoke bench (no index.js or src/host/ change), pack check, actionlint, interop, live-e2e, typecheck.

Checkpoint

{
  "pr": 1386,
  "claim": "Dev",
  "issue": 1381,
  "summary": "Settings → Workflows showed the raw host error when @flybot/workflow was not registered. A missing workflow/state call (bot/not-found, or Unknown FlyBot endpoint workflow/…) now says the Workflow plugin is not installed or not enabled, and that a default install includes @flybot/workflow. The same words are used in English and Chinese. Retry stays on that error. A registered plugin still lists factory presets and saved workflows and opens the flowchart.",
  "files": ["core/src/client/workflows.js", "core/src/client/i18n.js", "core/test/workflows-page.test.js", "core/client.js", "docs/subsystems/core-client.md", "changelog.d/1381-workflow-settings-hint.fixed.md"],
  "checks": { "ran": "TZ=UTC npm test in core (1797 pass); npm run lint; ds-bot-patches check; plugin tests 0 fail", "result": "green", "at": "205be1bea0603bfeac3422029cd8e7b9f71489a4" },
  "next": "none — ready for review"
}
Open in Web Open in Cursor 

Settings → Workflows showed the host string "Unknown FlyBot endpoint
workflow/state" when @flybot/workflow was not registered. Map bot/not-found
and that endpoint phrase to the install-or-enable hint, in English and
Chinese, and keep Retry. A present endpoint is unchanged.

Fixes #1381

Co-authored-by: Danyang Chen <birfychen@gmail.com>
@Birfy Birfy added the agent-pr Pull request opened by an agent label Oct 27, 2026 — with Cursor
@github-actions github-actions Bot added the risk:T1 Risk tier T1 (client, tests, generated files), set by the controller from the diff label Oct 27, 2026
@Birfy

Birfy commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Verdict: PASS at 205be1b
Written-by: Reviewer
Attestation: 205be1b role=Reviewer

Ran / reviewed:

Ready for merge queue.

@Birfy
Birfy added this pull request to the merge queue Oct 27, 2026
@github-actions github-actions Bot added the pass label Oct 27, 2026
Merged via the queue into main with commit 7b37b88 Oct 27, 2026
13 of 15 checks passed
@Birfy
Birfy deleted the fix-workflow-settings-missing-hint-1381 branch October 27, 2026 08:26
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass risk:T1 Risk tier T1 (client, tests, generated files), set by the controller from the diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings → Workflows: map missing workflow/state to a clear enable hint

2 participants