Skip to content

CI: run plugins/project in the plugin matrix, the nightly steps and the pack check (needs a gate-file signature) #2831

Open

Description

@Birfy

Written-by: Chief

Owner: Dev
Reviewer: Reviewer

plugins/project (@flybot/project, #2830) is a peer @flybot plugin now, but CI does not run it: three one-line wiring changes are deliberately left out of #2829 because test.yml is a gate file under policy/gates.json, and a gate-file change needs a Policy-sign: comment from someone other than the pull request's author. The wiring passed on the earlier tip that carried it (plugins (project) and package both green, run 42954591635), so this is coverage, not a defect in the plugin.

What is missing

  1. .github/workflows/test.yml — plugin: [tree, social, timeline, workflow] → add project, so the per-plugin job runs the 147-case suite.
  2. .github/workflows/nightly.yml — the nightly plugin steps do not name plugins/project.
  3. .github/scripts/check-pack.mjs — the pack list does not include plugins/project, so the package check packed five packages, not six.

Until it lands, core's own tests still exercise the domain (core/test/project-domain.js applies the plugin), and the root npm run verify lists plugins/project — only the per-plugin CI matrix and the pack check skip it.

Why it waits

policy-sign requires a comment from an account that is neither the pull request author (Birfy) nor a Bot, naming the tip it signs, and a Policy-sign: <comment id> line in the body. The owner has not yet said which account signs gate-file changes (#2683 waits on the same rule). This issue is the placeholder so the wiring is not lost; it goes in one pull request once an account can sign.

Do not pick this up as new work until the signing path is decided.

Activity

  1. Birfy commented on Nov 11, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Chief

    Prepared against main 1e27f10ed89d (#2829 merged), so this is the whole wiring in three hunks — it goes in one pull request as soon as an account that is not the PR author can sign a gate file (the rule #2124/#2683 wait on).

    1. .github/workflows/test.yml:86 — the plugin matrix gains the fifth plugin:

    -        plugin: [tree, social, timeline, workflow]
    +        plugin: [tree, social, timeline, workflow, project]

    2. .github/workflows/nightly.yml — two plugin-step blocks (line ~119 and ~181, the Windows leg and the other night), each adds the same pair after the workflow steps:

          - name: Plugin tests (project)
            working-directory: plugins/project
            run: npm test

    (same npm ci guard the neighbouring steps use, if the block has one.)

    3. .github/scripts/check-pack.mjs:9 — the pack list gains the package:

    -const packages = ['core', 'plugins/social', 'plugins/tree', 'plugins/timeline', 'plugins/workflow']
    +const packages = ['core', 'plugins/social', 'plugins/tree', 'plugins/timeline', 'plugins/workflow', 'plugins/project']

    The same wiring already ran green once: tip 7b38d3c6 of #2829 carried all three and the plugins (project) and package jobs passed (run 42954591635). The body of #2829 records it as deviation 7.

    No issue-to-close: this note closes nothing, Fixes #2831 goes on the pull request when it is opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions