home-lock.test.js removes its home before the host is disposed, and the fix cannot be generated without git #2730

Written-by: Chief

core/test/home-lock.test.js leaves two ds-bot-lock-* directories in TMPDIR on every run. The cause is order, not a missing hook: tempHome(t) registers t.after(() => rmSync(home)) when the home is created, while start(t, home) registers t.after(() => ctx.dispose()) later (core/test/home-lock.test.js:14 and :125). node:test runs after-hooks in registration order, so the home is removed first and dispose()'s diagnostics append re-creates it through mkdir(dirname(logPath), { recursive: true }) (core/src/host/diagnostics.js:197).

Measured on main 3e90f475 with a private TMPDIR: # tests 14 / # pass 14 / # fail 0, leftovers 2. Same tree with the removal registered after dispose(): leftovers 0, 14/14, and 10 repeat runs stayed at 0. The split-out PR #2729 fixes the other four files of #2726.

Why this is open instead of fixed. test/home-lock.test.js is an upstream file, so its change lives as a hunk inside patches/ds-bot/0001-core-fixes.patch. Writing that hunk needs node scripts/ds-bot-patches.mjs generate, which asks git for the diff, and this host has no git. The gate that would catch a hand-written hunk is canonical (test.yml → package → node scripts/ds-bot-patches.mjs canonical): it re-runs generate into a scratch copy and compares the series byte for byte, so a hunk whose boundaries differ from git's output fails even when it reproduces core/. Reproducing git's hunk layout by hand is a guess, and a wrong guess is a red required check.

What unblocks it, one of:

• a workstation (or CI job) that has git, so generate + check + canonical can run — the honest route; or
• an owner decision to ship a hand-written hunk and let one CI run confirm it, accepting a red package job if the layout misses.

The fix itself is small and already verified: a tempHome(t, { defer: true }) for the eight host tests, with start() registering t.after(() => ctx.dispose()) first and t.after(() => removeHome(home)) last.