client: a read-only window's Bot Details overview drops the model, permission and folder values #2457

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 6297dd65d81f41f6af8c684382d4d6f1
Branch: dev/2-p547-readonly-overview-values
Base: 43b2cb1
At: 2026-11-04T18:35:33Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment.
Written-by: FlyBot Lead

What happens

In a read-only window the Bot Details drawer's overview drops the Model, Permission and Working folder rows altogether — the values go with the controls.

core/src/client/details-drawer.js, overview block (bot && !bot.remote && tab === 'details'): the comment above it says "Say so once at the top and draw the read half only" (:381-383), and then each of the three entries is lockedWindow(roster) ? null : ... (:385-392). In a locked window the model name, the permission label and the folder are not drawn at all, so the person sees the read-only banner and after it no answer to "which model is this Bot on", "what may it do", "which folder does it work in".

The same drawer already has the intended shape one block up: the Bot's name is text, so it stays in both windows — value kept, control gone (:343-348). The three overview entries take the control away and the value with it.

Reproduction

Locked window (independent probe against the built core/client.js): model name drawn = false, permission label = false, workDir = false, with the read-only banner drawn. Writable window: all three true.

Red-first test, clean base, only the new test file present:

cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/details-overview-readonly.test.js
not ok 5 - P-547: a locked overview keeps the model, permission and folder values and draws no control
  the three values are drawn, not dropped with their controls
  0 !== 3
# tests 6  # pass 5  # fail 1

The writable half of the same file is green on the base, so the red lands exactly on the locked half.

Expected

• A locked overview still draws each of the three values as text: the model name (plus provider), the permission label, the folder name.
• No write control in the locked overview: no model menu, no permission control, no folder menu, no aria-haspopup="menu".
• A writable window is unchanged — same controls, same values.
• A Bot with no permission catalog set draws no permission row rather than an empty one.

Scope

• core/src/client/details-drawer.js — a read-only variant of the three entries; the writable branches untouched.
• core/test/details-overview-readonly.test.js — the locked half plus the writable no-regression half.
• core/client.js and the patches/ds-bot/0008 patch re-emitted with npm --prefix core run build + npm run generate (generated files, never hand-edited; a second generate must be a no-op).
• docs/subsystems/core-client.md — one line on the read-only overview (that page owns details-drawer.js).
• changelog.d/<issue>-details-overview-readonly-values.fixed.md.

Satisfiability checked out of tree: with that patch the locked cases read values = [model name + provider, "Workspace", "flybot" + folder path] and write controls = 0, while the writable drawer's canonical signature is byte-identical to the base (diff empty).

Duplicate check

live main 43b2cb17: grep -n "ReadOnlyOverview\|bt-readonly-value" core/src/client/details-drawer.js → 0 hits, and the overview still answers null in a locked window. Issues: #2391/#2392 (closed) are this same block's refusal line and its write entries — they removed the writes and took the values with them, which is this defect; #2400/#2401 (closed) are a group's overview; no open issue names the missing model / permission / folder values.

Lane

Single client-bundle lane: core/client.js + patches/ds-bot/0008. No open PR is in that lane now (#2424 landed 18:23:25Z).