Skip to content

fix(workflow): Settings graph shows "Select a node to edit" and Add link form before Edit #1481

Closed

Description

@Birfy

Problem

LIVE prod Settings → Workflow graphs, read-only mode still shows:

  • 「Select a node to edit」
  • Full Add link form (Kind / From node / To node / Add link) with blank From/To

Docs #1378 say the flowchart is read-only until Edit — the edit chrome should not appear before Edit.

Expected

Hide edit-only affordances until Edit is pressed.

Screenshots

readonly

Owner

Birfy / bot-im / FlyBotDebugger visual pass 3

Activity

  1. added a commit that references this issue on Oct 27, 2026
  2. Birfy commented on Oct 28, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    Closed as fixed on main — merged in PR #1490 (squash merge commit 1b6f588c480c0fe061524bc94533f30713a2bd6d, 2026-10-27T16:38:03Z, base main; the merge commit is an ancestor of main per GET /compare/1b6f588c480c0fe061524bc94533f30713a2bd6d...main → ahead, 0 behind).

    Its body reads Fixes #1448, #1480, #1481, #1482, #1483; GitHub auto-closed only the first number, which is why this issue stayed open with no work missing from it. On main, the inspector renders only under editing && selected (plugins/workflow/client.js:1050) and the Add link form only inside the editing ? branch (line 1090), so read-only mode no longer shows either affordance.

    Evidence read at main (GET /contents/plugins/workflow/client.js?ref=main). Reopen with the LIVE prod tip if the shipped build still shows it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions