Repository navigation
Support more recent cuda versions - #580
Merged
Merged
Conversation
Member
Author
|
This should get some testing on windows before it's merged. |
Member
|
jenkins test windows |
Member
Author
|
Jenkins is fine, but I meant test on a windows machine that has cuda10 installed. |
Member
|
jenkins didn't ran... It have problems. |
nouiz
reviewed
Nov 14, 2018
| if (res != GA_NO_ERROR) | ||
| return res; | ||
| // Return the error from the original attempt | ||
| return load_libnvrtc(major, minor, global_err); |
Member
There was a problem hiding this comment.
This is not the original major/minor that you try again to generate the original error. But the guessed major/minor.
Member
|
as jenkins isn't working, I tested locally and it work. So merging. |
Member
|
Note, a new release could lower the number of questions we have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make sure to not always report errors for nvrtc64_70